Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove deployment of slack notifier #1657

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Jan 7, 2025

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@arealmaas arealmaas requested review from a team as code owners January 7, 2025 14:41
Copy link
Contributor

coderabbitai bot commented Jan 7, 2025

📝 Walkthrough

Walkthrough

This pull request involves the comprehensive removal of the Slack notifier deployment functionality across multiple GitHub workflow files. The changes include deleting the deploy-slack-notifier job from CI/CD workflows for main, production, staging, and YT01 environments, removing the workflow for deploying Azure Functions, and updating Slack message sending configurations. The modifications simplify the CI/CD pipeline by eliminating the Slack notifier deployment step and associated references.

Changes

File Change Summary
.github/slack-templates/pipeline-failed.json Removed "Slack Notifier" status from the job status section
.github/workflows/ci-cd-*.yml (main, prod, staging, yt01) - Removed deploy-slack-notifier job
- Updated send-slack-message-on-failure job dependencies
- Removed slack_notifier_status input
.github/workflows/workflow-deploy-function.yml Completely removed workflow for deploying Azure Functions
.github/workflows/workflow-send-ci-cd-status-slack-message.yml - Removed slack_notifier_status input
- Eliminated Slack notifier status processing logic

Possibly related PRs

Suggested reviewers

  • oskogstad

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 554fc8b and 57a8a77.

📒 Files selected for processing (7)
  • .github/slack-templates/pipeline-failed.json (1 hunks)
  • .github/workflows/ci-cd-main.yml (0 hunks)
  • .github/workflows/ci-cd-prod.yml (1 hunks)
  • .github/workflows/ci-cd-staging.yml (1 hunks)
  • .github/workflows/ci-cd-yt01.yml (1 hunks)
  • .github/workflows/workflow-deploy-function.yml (0 hunks)
  • .github/workflows/workflow-send-ci-cd-status-slack-message.yml (0 hunks)
💤 Files with no reviewable changes (3)
  • .github/workflows/workflow-send-ci-cd-status-slack-message.yml
  • .github/workflows/ci-cd-main.yml
  • .github/workflows/workflow-deploy-function.yml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Dry run deploy infrastructure / Deploy to test
  • GitHub Check: build / build-and-test
🔇 Additional comments (4)
.github/slack-templates/pipeline-failed.json (1)

26-26: LGTM! Slack notifier status removal is consistent.

The removal of the Slack notifier status from the pipeline failure message template aligns with the removal of the deploy-slack-notifier job across all CI/CD workflows.

.github/workflows/ci-cd-staging.yml (1)

137-137: LGTM! Job dependencies updated correctly.

The send-slack-message-on-failure job's dependencies have been properly updated to remove the deploy-slack-notifier while maintaining essential dependencies on infrastructure, apps, E2E tests, schema publishing, and the publish job.

✅ Verification successful

Slack notification changes verified successfully

The workflow has been properly updated to remove the deploy-slack-notifier job while maintaining a clean notification system using the reusable workflow. The send-slack-message-on-failure job's dependencies are correctly configured to monitor all critical pipeline stages.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify no remaining references to slack notifier in the workflow
rg -l "deploy-slack-notifier" .github/workflows/ci-cd-staging.yml || echo "No references found - good!"

Length of output: 130


Script:

#!/bin/bash
# Search for any slack-related patterns and show job definitions
rg -i "slack" .github/workflows/ci-cd-staging.yml -C 5

# Show all job definitions and their dependencies
rg "^\s{2,}[a-zA-Z0-9_-]+:\s*$|^\s{4,}needs:" .github/workflows/ci-cd-staging.yml

Length of output: 1938

.github/workflows/ci-cd-yt01.yml (1)

162-162: LGTM! Job dependencies aligned with other environments.

The send-slack-message-on-failure job's dependencies have been properly updated to remove the deploy-slack-notifier while maintaining all YT01-specific dependencies, including performance tests.

✅ Verification successful

Verified: Slack notifier dependency properly removed

The workflow file has been correctly updated with no remaining references to the deploy-slack-notifier job, while maintaining all necessary dependencies for the CI/CD pipeline and Slack notifications.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify no remaining references to slack notifier in the workflow
rg -l "deploy-slack-notifier" .github/workflows/ci-cd-yt01.yml || echo "No references found - good!"

Length of output: 127


Script:

#!/bin/bash
# Search for all 'needs:' declarations in the workflow file
rg "needs:" -A 2 .github/workflows/ci-cd-yt01.yml

Length of output: 1595

.github/workflows/ci-cd-prod.yml (1)

161-161: LGTM! Production workflow simplified correctly.

The send-slack-message-on-failure job's dependencies have been properly updated for the production environment, maintaining only the essential infrastructure and apps deployment dependencies.

Consider updating the deployment documentation to remove any references to the Slack notifier functionality, if they exist.

✅ Verification successful

Documentation is already clean - no updates needed

The documentation doesn't contain any references to the Slack notifier functionality, so no updates are required.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining documentation of the Slack notifier
rg -l "slack.?notifier" docs/ || echo "No documentation references found - good!"

Length of output: 124


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Jan 7, 2025

@arealmaas arealmaas merged commit 6ecfd89 into main Jan 7, 2025
26 checks passed
@arealmaas arealmaas deleted the ci/remove-deployment-of-slack-notifier branch January 7, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants