Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Dialogporten Serviceowner client library #1513

Open
wants to merge 119 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 115 commits
Commits
Show all changes
119 commits
Select commit Hold shift + click to select a range
d33461f
Squash
Fargekritt Nov 7, 2024
afa5316
Workflow test
Fargekritt Nov 25, 2024
d4b96db
Workflow
Fargekritt Nov 25, 2024
64db1f9
Workflow
Fargekritt Nov 25, 2024
cbd3e76
Workflow test
Fargekritt Nov 25, 2024
3689808
Workflow
Fargekritt Nov 25, 2024
7f17006
Nuget push workflow!
Fargekritt Nov 25, 2024
324cf3f
OI
Fargekritt Nov 25, 2024
288175c
Changed file test
Fargekritt Nov 25, 2024
e538c94
Update
Fargekritt Nov 25, 2024
7135268
Upd
Fargekritt Nov 25, 2024
2b9238b
up
Fargekritt Nov 25, 2024
a6e66b5
List all changes
Fargekritt Nov 26, 2024
eb590e1
hm
Fargekritt Nov 26, 2024
b499151
no da
Fargekritt Nov 26, 2024
f8691de
changes
Fargekritt Nov 26, 2024
ed42f73
testing again
Fargekritt Nov 26, 2024
2f613c0
oioi
Fargekritt Nov 26, 2024
71aefc8
no da!
Fargekritt Nov 26, 2024
1fb84e6
Added comments
Fargekritt Nov 26, 2024
60571b6
Workflow testing
Fargekritt Nov 27, 2024
2640a4b
funk
Fargekritt Nov 27, 2024
1f3c8b3
no da
Fargekritt Nov 27, 2024
76b5964
hm
Fargekritt Nov 27, 2024
d3062a2
no da
Fargekritt Nov 27, 2024
b09f6d4
oioi
Fargekritt Nov 27, 2024
fd8907e
Workflow maybe done
Fargekritt Nov 28, 2024
41a2eb5
Comment
Fargekritt Nov 28, 2024
1bdca4d
.NET9 adds its own base64URL, can remove the custom one
Fargekritt Nov 28, 2024
1b7f5a7
Cleaned up test
Fargekritt Nov 28, 2024
c4f5daf
Workflow test
Fargekritt Nov 28, 2024
56a5ebe
no
Fargekritt Nov 28, 2024
af4f6a3
Big finding out
Fargekritt Nov 28, 2024
708b09e
hm
Fargekritt Nov 28, 2024
4a15f4a
Clean up
Fargekritt Nov 28, 2024
3849c42
Arg
Fargekritt Nov 28, 2024
0894c17
hmm
Fargekritt Nov 28, 2024
329e8eb
Updated README.md
Fargekritt Nov 28, 2024
f46deb3
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Nov 28, 2024
2a15b37
Clean up
Fargekritt Nov 29, 2024
431cc85
Workflow cleanup
Fargekritt Nov 29, 2024
4def26a
README updated
Fargekritt Nov 29, 2024
ff1d0f8
Created Basic test structure
Fargekritt Dec 5, 2024
347d729
Added more tests. Now test Create, Path, Get, and Purge
Fargekritt Dec 5, 2024
cdee031
Test fixture
Fargekritt Dec 6, 2024
d75e113
Removed generated file from test proj to not make conflicts
Fargekritt Dec 6, 2024
054c9ce
Updated how base url is set
Fargekritt Dec 6, 2024
b85b008
Created SearchTest
Fargekritt Dec 6, 2024
457e9b7
Created Get test
Fargekritt Dec 6, 2024
81df398
Updated tests to use local nuget
Fargekritt Dec 10, 2024
020e538
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Dec 10, 2024
bf88cdc
Created UpdateTest
Fargekritt Dec 11, 2024
aac7bfa
Added deleteTest
Fargekritt Dec 11, 2024
21c9e87
Test refactor
Fargekritt Dec 11, 2024
4655774
Search multiple test
Fargekritt Dec 12, 2024
40f54fe
Multiple dialog search, and Invalid Patch test
Fargekritt Dec 12, 2024
0c663ee
Invalid Update test
Fargekritt Dec 12, 2024
5a3c578
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Dec 12, 2024
a08e486
Updated tests
Fargekritt Dec 13, 2024
e71db25
Cleanup
Fargekritt Dec 13, 2024
b96fb3b
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Dec 13, 2024
a82f91d
Updated tests
Fargekritt Dec 13, 2024
aba1aec
Cleanup
Fargekritt Dec 13, 2024
2d5dd74
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Dec 13, 2024
075854b
Comments
Fargekritt Dec 13, 2024
b952394
Update src/Digdir.Library.Dialogporten.WebApiClient/Config/Maskinport…
Fargekritt Dec 13, 2024
9fd4304
Clean up
Fargekritt Dec 13, 2024
8d6b5c0
Merge remote-tracking branch 'origin/feat/add-WepApiClient-project' i…
Fargekritt Dec 13, 2024
2b203a1
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Jan 17, 2025
e46f868
Updated Sample and RefitterInterfac
Fargekritt Jan 20, 2025
c5ae633
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Jan 20, 2025
68d65bc
* Updated comments on IDialogportenSettings
Fargekritt Jan 20, 2025
bcba03c
Updated to refitter v1.5.0
Fargekritt Jan 20, 2025
f159e5d
Removed comments
Fargekritt Jan 20, 2025
e1ae100
Clean up
Fargekritt Jan 20, 2025
8588f26
sln broken? possible from earlier merge from main
Fargekritt Jan 20, 2025
a3113dc
Added secrets to test workflow
Fargekritt Jan 20, 2025
1793fd7
hm
Fargekritt Jan 20, 2025
0299d68
test
Fargekritt Jan 20, 2025
8a72bec
Test now uses env variables
Fargekritt Jan 20, 2025
b034ddb
hm
Fargekritt Jan 20, 2025
99ef7ec
testing
Fargekritt Jan 20, 2025
d60ac48
bruh
Fargekritt Jan 20, 2025
5e5778c
oi
Fargekritt Jan 21, 2025
f20e113
Test
Fargekritt Jan 21, 2025
a3496be
nani
Fargekritt Jan 21, 2025
65da398
no da
Fargekritt Jan 21, 2025
8e7ac5b
funk
Fargekritt Jan 21, 2025
480f159
add environemnt for test
arealmaas Jan 21, 2025
40aec95
est
Fargekritt Jan 21, 2025
5b2fca1
oi
Fargekritt Jan 21, 2025
9ca5505
Wth
Fargekritt Jan 21, 2025
f21d71d
oioioi
Fargekritt Jan 21, 2025
810a809
work neow?
arealmaas Jan 21, 2025
e327f47
ay
Fargekritt Jan 21, 2025
837b133
Update tests
Fargekritt Jan 21, 2025
156d3da
Updated tests
Fargekritt Jan 21, 2025
741833a
Updated tests again
Fargekritt Jan 21, 2025
4dfbf76
gm
Fargekritt Jan 21, 2025
0025468
WebApiClient Cleanup
Fargekritt Jan 21, 2025
febc391
Sample cleanup
Fargekritt Jan 21, 2025
377cef1
m
Fargekritt Jan 21, 2025
a680681
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Jan 21, 2025
024e3cb
Updated RefitterInterface
Fargekritt Jan 21, 2025
44842d9
Build testing
Fargekritt Jan 23, 2025
199607c
test
Fargekritt Jan 23, 2025
3c0d18d
test
Fargekritt Jan 23, 2025
3c9762e
added swagger to client
Fargekritt Jan 23, 2025
acba3c3
Merge branch 'main' into feat/add-WepApiClient-project
Fargekritt Jan 23, 2025
1d5d9ac
Correct configuratuin
Fargekritt Jan 23, 2025
948579b
Is it working?
Fargekritt Jan 23, 2025
fd86499
Updated SwaggerSnapshotTests to use Swaggger.json from the build of W…
Fargekritt Jan 23, 2025
00ddab2
Sorting still needed
Fargekritt Jan 23, 2025
47bfc21
Sorted swagger
Fargekritt Jan 23, 2025
025dadb
Cleanup refitterTests
Fargekritt Jan 23, 2025
a58f912
Is it done?!
Fargekritt Jan 23, 2025
74170c6
Now done probably!
Fargekritt Jan 23, 2025
c6d4a3f
Clean up
Fargekritt Jan 24, 2025
3064ea0
Clean up
Fargekritt Jan 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci-cd-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ jobs:
uses: ./.github/workflows/workflow-build-and-test.yml
needs: [check-for-changes]
if: ${{ github.event_name == 'workflow_dispatch' || needs.check-for-changes.outputs.hasBackendChanges == 'true' || needs.check-for-changes.outputs.hasTestChanges == 'true' }}
secrets:
DIALOGPORTEN_MASKINPORTEN_ENCODEDJWK: ${{ secrets.DIALOGPORTEN_MASKINPORTEN_ENCODEDJWK }}
DIALOGPORTEN_MASKINPORTEN_CLIENTID: ${{ secrets.DIALOGPORTEN_MASKINPORTEN_CLIENTID }}
DIALOGPORTEN_MASKINPORTEN_SCOPE: ${{ secrets.DIALOGPORTEN_MASKINPORTEN_SCOPE }}
ED25519KEYS_PRIMARY_KID: ${{ secrets.ED25519KEYS_PRIMARY_KID }}
ED25519KEYS_PRIMARY_PUBLICCOMPONENT: ${{ secrets.ED25519KEYS_PRIMARY_PUBLICCOMPONENT }}

publish:
name: Build and publish docker images
Expand Down Expand Up @@ -108,6 +114,16 @@ jobs:
version: ${{ needs.get-current-version.outputs.version }}-${{ needs.generate-git-short-sha.outputs.gitShortSha }}
runMigration: ${{ github.event_name == 'workflow_dispatch' || needs.check-for-changes.outputs.hasMigrationChanges == 'true' }}

publish-sdk-to-nuget:
uses: ./.github/workflows/workflow-publish-nuget.yml
needs: [ get-current-version, generate-git-short-sha, check-for-changes ]
if: ${{ needs.check-for-changes.outputs.hasBackendChanges == 'true' || needs.check-for-changes.outputs.hasTestChanges == 'true' }}
with:
version: ${{ needs.get-current-version.outputs.version }}-rc.${{ needs.generate-git-short-sha.outputs.gitShortSha }}
path: $(find . -name '*Digdir.Library.Dialogporten.WebApiClient.csproj' -printf "%p" -quit)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Replace shell command with predefined path.

Using a shell command in YAML value is problematic as it:

  • May fail on Windows runners
  • Makes the workflow less maintainable

Consider using a predefined path or workflow input parameter instead:

-      path: $(find . -name '*Digdir.Library.Dialogporten.WebApiClient.csproj' -printf "%p"  -quit)
+      path: 'src/Digdir.Library.Dialogporten.WebApiClient/Digdir.Library.Dialogporten.WebApiClient.csproj'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
path: $(find . -name '*Digdir.Library.Dialogporten.WebApiClient.csproj' -printf "%p" -quit)
path: 'src/Digdir.Library.Dialogporten.WebApiClient/Digdir.Library.Dialogporten.WebApiClient.csproj'

secrets:
NUGET_API_KEY: ${{ secrets.NUGET_API_TEST_KEY }}

publish-schema-npm:
name: Deploy schema npm package
needs: [check-for-changes, get-current-version, generate-git-short-sha, deploy-apps]
Expand Down
23 changes: 14 additions & 9 deletions .github/workflows/ci-cd-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@

on:
pull_request:
branches: [main]
branches: [ main ]
paths-ignore:
- "tests/k6/**"
- "CHANGELOG.md"

jobs:
generate-git-short-sha:
Expand All @@ -19,23 +18,29 @@ jobs:
check-for-changes:
name: Check for changes
uses: ./.github/workflows/workflow-check-for-changes.yml

build:
uses: ./.github/workflows/workflow-build-and-test.yml
needs: [check-for-changes]
needs: [ check-for-changes ]
if: ${{ needs.check-for-changes.outputs.hasBackendChanges == 'true' || needs.check-for-changes.outputs.hasTestChanges == 'true' }}

secrets:
DIALOGPORTEN_MASKINPORTEN_ENCODEDJWK: ${{ secrets.DIALOGPORTEN_MASKINPORTEN_ENCODEDJWK }}
DIALOGPORTEN_MASKINPORTEN_CLIENTID: ${{ secrets.DIALOGPORTEN_MASKINPORTEN_CLIENTID }}
DIALOGPORTEN_MASKINPORTEN_SCOPE: ${{ secrets.DIALOGPORTEN_MASKINPORTEN_SCOPE }}
ED25519KEYS_PRIMARY_KID: ${{ secrets.ED25519KEYS_PRIMARY_KID }}
ED25519KEYS_PRIMARY_PUBLICCOMPONENT: ${{ secrets.ED25519KEYS_PRIMARY_PUBLICCOMPONENT }}

build-infrastructure:
uses: ./.github/workflows/workflow-build-infrastructure.yml
needs: [check-for-changes]
needs: [ check-for-changes ]
if: ${{ always() && needs.check-for-changes.outputs.hasInfraChanges == 'true' }}
secrets:
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
with:
environment: "test"

dry-run-deploy-infra:
name: Dry run deploy infrastructure
uses: ./.github/workflows/workflow-deploy-infra.yml
Expand Down Expand Up @@ -93,7 +98,7 @@ jobs:
delete-github-deployments:
name: Delete GitHub deployments
uses: ./.github/workflows/workflow-delete-deployments.yml
needs: [dry-run-deploy-apps, dry-run-deploy-infra]
needs: [ dry-run-deploy-apps, dry-run-deploy-infra ]
if: ${{ always() && !failure() && !cancelled() }}
with:
gitSha: ${{ github.event.pull_request.head.sha }}
gitSha: ${{ github.event.pull_request.head.sha }}
10 changes: 10 additions & 0 deletions .github/workflows/ci-cd-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,16 @@ jobs:
version: ${{ needs.get-current-version.outputs.version }}
runMigration: ${{ github.event_name == 'workflow_dispatch' || needs.check-for-changes.outputs.hasMigrationChanges == 'true' }}

publish-sdk-to-nuget:
uses: ./.github/workflows/workflow-publish-nuget.yml
needs: [ get-current-version, check-for-changes ]
if: ${{ needs.check-for-changes.outputs.hasBackendChanges == 'true' || needs.check-for-changes.outputs.hasTestChanges == 'true' }}
with:
version: ${{ needs.get-current-version.outputs.version }}
path: $(find . -name '*Digdir.Library.Dialogporten.WebApiClient.csproj' -printf "%p" -quit)
secrets:
NUGET_API_KEY: ${{ secrets.NUGET_API_TEST_KEY }}
Comment on lines +96 to +104
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve robustness of project file path resolution

The current implementation has several potential issues:

  1. The $(find ...) command is embedded in the path parameter and uses shell syntax that might not work consistently in GitHub Actions
  2. The pattern could match multiple files if there are test projects with similar names

Consider using a dedicated step to find the project file:

  publish-sdk-to-nuget:
    uses: ./.github/workflows/workflow-publish-nuget.yml
    needs: [ get-current-version, check-for-changes ]
    if: ${{ needs.check-for-changes.outputs.hasBackendChanges == 'true' || needs.check-for-changes.outputs.hasTestChanges == 'true' }}
+   run: |
+     PROJECT_PATH=$(find . -name "Digdir.Library.Dialogporten.WebApiClient.csproj" -not -path "*/test/*" -print -quit)
+     echo "PROJECT_PATH=$PROJECT_PATH" >> $GITHUB_ENV
    with:
      version: ${{ needs.get-current-version.outputs.version }}
-     path: $(find . -name '*Digdir.Library.Dialogporten.WebApiClient.csproj' -printf "%p"  -quit)
+     path: ${{ env.PROJECT_PATH }}
    secrets:
      NUGET_API_KEY: ${{ secrets.NUGET_API_TEST_KEY }}

This approach:

  1. Uses a dedicated step for path resolution
  2. Excludes test projects using -not -path "*/test/*"
  3. Stores the result in an environment variable
  4. Fails fast if the project file is not found

Committable suggestion skipped: line range outside the PR's diff.


store-apps-version:
name: Store Latest Deployed Apps Version as GitHub Variable
needs: [deploy-apps, get-current-version]
Expand Down
19 changes: 19 additions & 0 deletions .github/workflows/workflow-build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,22 @@ name: Build and test .NET
on:
workflow_dispatch:
workflow_call:
secrets:
DIALOGPORTEN_MASKINPORTEN_ENCODEDJWK:
required: true
DIALOGPORTEN_MASKINPORTEN_CLIENTID:
required: true
DIALOGPORTEN_MASKINPORTEN_SCOPE:
required: true
ED25519KEYS_PRIMARY_KID:
required: true
ED25519KEYS_PRIMARY_PUBLICCOMPONENT:
required: true

jobs:
build-and-test:
runs-on: ubuntu-latest
environment: test
steps:
- uses: actions/checkout@v4

Expand All @@ -22,4 +34,11 @@ jobs:
run: dotnet build --no-restore --configuration Release

- name: Test
env:
DialogportenSettings:Environment: "test"
DialogportenSettings:Maskinporten:ClientId: ${{secrets.DIALOGPORTEN_MASKINPORTEN_CLIENTID}}
DialogportenSettings:Maskinporten:Scope: ${{secrets.DIALOGPORTEN_MASKINPORTEN_SCOPE}}
DialogportenSettings:Maskinporten:EncodedJwk: ${{secrets.DIALOGPORTEN_MASKINPORTEN_ENCODEDJWK}}
Ed25519Keys:Primary:Kid: "${{secrets.ED25519KEYS_PRIMARY_KID}}"
Ed25519Keys:Primary:PublicComponent: "${{secrets.ED25519KEYS_PRIMARY_PUBLICCOMPONENT}}"
run: dotnet test --no-build --configuration Release
62 changes: 62 additions & 0 deletions .github/workflows/workflow-publish-nuget.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: "Publish nuget package"

on:
workflow_call:
inputs:
version:
description: "Version"
required: true
type: string
Fargekritt marked this conversation as resolved.
Show resolved Hide resolved
path:
description: "Path to project"
required: true
type: string
source:
description: "Nuget Source"
required: false
type: string
default: https://int.nugettest.org
secrets:
NUGET_API_KEY:
required: true
jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- name: Checkout
uses: actions/checkout@v4
- name: set PROJECT variable to point to project
run: |
PROJECT="${{inputs.path}}"
echo "PROJECT ${PROJECT}"
echo "PROJECT=${PROJECT}" >> "$GITHUB_ENV"

- name: Set up .NET
uses: actions/setup-dotnet@v4
with:
global-json-file: ./global.json

- name: Build
run: dotnet build --configuration Release /p:Version="${{ inputs.version }}" "${PROJECT}"

- name: Pack with debug symbols
run: dotnet pack --configuration Release /p:Version="${{ inputs.version }}" -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg --output . "${PROJECT}"

- name: Upload artifact
uses: actions/upload-artifact@v4
with:
name: package
path: '*.*nupkg'
push:
needs: build
runs-on: ubuntu-latest
steps:
- name: Download artifact
uses: actions/download-artifact@v4
with:
name: package

- name: Push to NuGet
run: dotnet nuget push *.nupkg --source "${{ inputs.source }}" --api-key ${{secrets.NUGET_API_KEY}}

14 changes: 14 additions & 0 deletions .refitter
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kalle denne WebApiClient.refitter. e.l og så kan vi heller spesifisere den i refitter-commanden?

refitter ./openapi.json --settings-file ./WebApiClient.refitter elns

"openApiPath": "docs/schema/V1/swagger.verified.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blir refitter bare kalt kun en gang? Eller gjør vi det hver gang API endrer seg? Isåfall burde vi kanskje ha det som en del av bygg-steget? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

akkurat nå blir den generert av en test lignene swaggerSnapshot testen. men holder på å prøver meg litt frem for å finne en løsning

"namespace": "Digdir.Library.Dialogporten.WebApiClient.Features.V1",
"outputFolder": "src/Digdir.Library.Dialogporten.WebApiClient/Features/V1/",
"operationNameGenerator": "SingleClientFromOperationId",
"multipleInterfaces": "ByTag",
"includeTags": [

],
"useCancellationTokens": true,
"returnIApiResponse": true,
"useDynamicQuerystringParameters": true,
"outputFilename": "RefitterInterface.cs"
}
26 changes: 25 additions & 1 deletion Digdir.Domain.Dialogporten.sln
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Domain.Dialogporten.
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Tool.Dialogporten.Ed25519KeyPairGenerator", "src\Digdir.Tool.Dialogporten.Ed25519KeyPairGenerator\Digdir.Tool.Dialogporten.Ed25519KeyPairGenerator.csproj", "{030909AA-5B61-46B4-9B74-0D2D779478FF}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Domain.Dialogporten.WebApi.Integration.Tests", "tests\Digdir.Domain.Dialogporten.WebApi.Integration.Tests\Digdir.Domain.Dialogporten.WebApi.Integration.Tests.csproj", "{42004236-D45C-4A1F-9FF9-CF12B7388389}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Domain.Dialogporten.WebApi.Unit.Tests", "tests\Digdir.Domain.Dialogporten.WebApi.Unit.Tests\Digdir.Domain.Dialogporten.WebApi.Unit.Tests.csproj", "{42004236-D45C-4A1F-9FF9-CF12B7388389}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Domain.Dialogporten.GraphQL", "src\Digdir.Domain.Dialogporten.GraphQL\Digdir.Domain.Dialogporten.GraphQL.csproj", "{234FE24D-1047-4E29-A625-1EB406C37A2D}"
EndProject
Expand All @@ -63,6 +63,14 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Domain.Dialogporten.
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Library.Utils.AspNet", "src\Digdir.Library.Utils.AspNet\Digdir.Library.Utils.AspNet.csproj", "{6A485C65-3613-4A49-A16F-2789119F6F38}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "WebApiClient", "WebApiClient", "{9B809C3A-B169-4599-A2D3-A25E87C510FC}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Library.Dialogporten.WebApiClient", "src\Digdir.Library.Dialogporten.WebApiClient\Digdir.Library.Dialogporten.WebApiClient.csproj", "{714FBB11-ADC0-44E8-A768-D1A59D641D31}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Library.Dialogporten.WebApiClient.Sample", "src\Digdir.Library.Dialogporten.WebApiClient.Sample\Digdir.Library.Dialogporten.WebApiClient.Sample.csproj", "{F8CB7159-4346-4436-9C35-BFCFDDE5DC2B}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Digdir.Library.Dialogporten.WebApiClient.Integration.Tests", "tests\Digdir.Library.Dialogporten.WebApiClient.Integration.Tests\Digdir.Library.Dialogporten.WebApiClient.Integration.Tests.csproj", "{7014AC47-0DF5-48C1-BD72-EE587FF3278B}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -153,6 +161,18 @@ Global
{6A485C65-3613-4A49-A16F-2789119F6F38}.Debug|Any CPU.Build.0 = Debug|Any CPU
{6A485C65-3613-4A49-A16F-2789119F6F38}.Release|Any CPU.ActiveCfg = Release|Any CPU
{6A485C65-3613-4A49-A16F-2789119F6F38}.Release|Any CPU.Build.0 = Release|Any CPU
{714FBB11-ADC0-44E8-A768-D1A59D641D31}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{714FBB11-ADC0-44E8-A768-D1A59D641D31}.Debug|Any CPU.Build.0 = Debug|Any CPU
{714FBB11-ADC0-44E8-A768-D1A59D641D31}.Release|Any CPU.ActiveCfg = Release|Any CPU
{714FBB11-ADC0-44E8-A768-D1A59D641D31}.Release|Any CPU.Build.0 = Release|Any CPU
{F8CB7159-4346-4436-9C35-BFCFDDE5DC2B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{F8CB7159-4346-4436-9C35-BFCFDDE5DC2B}.Debug|Any CPU.Build.0 = Debug|Any CPU
{F8CB7159-4346-4436-9C35-BFCFDDE5DC2B}.Release|Any CPU.ActiveCfg = Release|Any CPU
{F8CB7159-4346-4436-9C35-BFCFDDE5DC2B}.Release|Any CPU.Build.0 = Release|Any CPU
{7014AC47-0DF5-48C1-BD72-EE587FF3278B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{7014AC47-0DF5-48C1-BD72-EE587FF3278B}.Debug|Any CPU.Build.0 = Debug|Any CPU
{7014AC47-0DF5-48C1-BD72-EE587FF3278B}.Release|Any CPU.ActiveCfg = Release|Any CPU
{7014AC47-0DF5-48C1-BD72-EE587FF3278B}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -182,6 +202,10 @@ Global
{0900E3CF-F9D8-4B29-957F-484B3B028D6D} = {320B47A0-5EB8-4B6E-8C84-90633A1849CA}
{E389C7C8-9610-40AC-86DC-769B1B7DC78E} = {CADB8189-4AA1-4732-844A-C41DBF3EC8B7}
{6A485C65-3613-4A49-A16F-2789119F6F38} = {096E9B69-6783-4446-A895-0B6D7729A0D9}
{9B809C3A-B169-4599-A2D3-A25E87C510FC} = {096E9B69-6783-4446-A895-0B6D7729A0D9}
{714FBB11-ADC0-44E8-A768-D1A59D641D31} = {9B809C3A-B169-4599-A2D3-A25E87C510FC}
{F8CB7159-4346-4436-9C35-BFCFDDE5DC2B} = {9B809C3A-B169-4599-A2D3-A25E87C510FC}
{7014AC47-0DF5-48C1-BD72-EE587FF3278B} = {CADB8189-4AA1-4732-844A-C41DBF3EC8B7}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {B2FE67FF-7622-4AFB-AD8E-961B6A39D888}
Expand Down
2 changes: 1 addition & 1 deletion docs/schema/V1/swagger.verified.json
Original file line number Diff line number Diff line change
Expand Up @@ -7060,7 +7060,7 @@
},
"servers": [
{
"url": "https://altinn-dev-api.azure-api.net/dialogporten"
"url": "https://localhost:7214/"
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,41 @@
<ItemGroup>
<PackageReference Include="Azure.Identity" Version="1.13.2" />
<PackageReference Include="FastEndpoints.Swagger" Version="5.33.0"/>
<PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="9.0.1" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="9.0.1" />
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="9.0.1" />
<PackageReference Include="Serilog.Sinks.OpenTelemetry" Version="4.1.1" />
<PackageReference Include="Microsoft.Azure.AppConfiguration.AspNetCore" Version="8.0.0" />
<PackageReference Include="Serilog.AspNetCore" Version="9.0.0" />
<PackageReference Include="Serilog.Enrichers.Environment" Version="3.0.1" />
<PackageReference Include="Azure.Monitor.OpenTelemetry.AspNetCore" Version="1.2.0" />
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.10.0" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.10.0" />
<PackageReference Include="OpenTelemetry.Instrumentation.EntityFrameworkCore" Version="1.10.0-beta.1" />
<PackageReference Include="OpenTelemetry" Version="1.10.0" />
<PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.10.0" />
<PackageReference Include="Npgsql.OpenTelemetry" Version="9.0.2" />
<PackageReference Include="ZiggyCreatures.FusionCache.OpenTelemetry" Version="1.4.1" />
<PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="9.0.1"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hva har skjedd her? Det er litt vanskelig å se hvilke endringer denne fila faktisk inneholder når space på slutten av hver package reference er blitt fjernet og alt er å regne som en endring. Kan du gjøre slik at change settet kun inneholder det som faktisk er endret?

<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="9.0.1"/>
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="9.0.1"/>
<PackageReference Include="NSwag.Generation" Version="14.2.0"/>
<PackageReference Include="NSwag.MSBuild" Version="14.2.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Serilog.Sinks.OpenTelemetry" Version="4.1.1"/>

<PackageReference Include="Microsoft.Azure.AppConfiguration.AspNetCore" Version="8.0.0"/>
<PackageReference Include="Serilog.AspNetCore" Version="9.0.0"/>
<PackageReference Include="Serilog.Enrichers.Environment" Version="3.0.1"/>
<PackageReference Include="Azure.Monitor.OpenTelemetry.AspNetCore" Version="1.2.0"/>
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.10.0"/>
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.10.0"/>
<PackageReference Include="OpenTelemetry.Instrumentation.EntityFrameworkCore" Version="1.10.0-beta.1"/>
<PackageReference Include="OpenTelemetry" Version="1.10.0"/>
<PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.10.0"/>
<PackageReference Include="Npgsql.OpenTelemetry" Version="9.0.2"/>
<PackageReference Include="ZiggyCreatures.FusionCache.OpenTelemetry" Version="1.4.1"/>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\Digdir.Domain.Dialogporten.Application\Digdir.Domain.Dialogporten.Application.csproj" />
<ProjectReference Include="..\Digdir.Domain.Dialogporten.Infrastructure\Digdir.Domain.Dialogporten.Infrastructure.csproj" />
<ProjectReference Include="..\Digdir.Library.Utils.AspNet\Digdir.Library.Utils.AspNet.csproj" />
<ProjectReference Include="..\Digdir.Tool.Dialogporten.GenerateFakeData\Digdir.Tool.Dialogporten.GenerateFakeData.csproj" />
<ProjectReference Include="..\Digdir.Domain.Dialogporten.Application\Digdir.Domain.Dialogporten.Application.csproj"/>
<ProjectReference Include="..\Digdir.Domain.Dialogporten.Infrastructure\Digdir.Domain.Dialogporten.Infrastructure.csproj"/>
<ProjectReference Include="..\Digdir.Library.Utils.AspNet\Digdir.Library.Utils.AspNet.csproj"/>
<ProjectReference Include="..\Digdir.Tool.Dialogporten.GenerateFakeData\Digdir.Tool.Dialogporten.GenerateFakeData.csproj"/>
</ItemGroup>

<Target Name="NSwag" AfterTargets="Build" Condition="$(Configuration)=='Release'">
<Exec WorkingDirectory="$(ProjectDir)" EnvironmentVariables="ASPNETCORE_ENVIRONMENT=Development" Command="$(NSwagExe_net90) aspnetcore2openapi /nobuild:true /project:$(MSBuildProjectFullPath) /configuration:$(Configuration) /output:$(TargetDir)/swagger.json"/>
</Target>




</Project>
Loading
Loading