fix(azure): ensure monitor workspace is reachable

[arealmaas]

Description

Opening up all ports, and we can rather restrict more when we see what ports need to be open here.

Related Issue(s)

• #{issue number}

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

• New Features

  • Enhanced Azure network security group configurations with broader traffic allowances.
  • Introduced specific inbound rules for container apps, improving security management.

• Bug Fixes

  • Renamed and updated existing security rules for clarity and functionality.

These changes improve the flexibility and security of network configurations within the Azure environment.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the Bicep configuration for Azure network security groups (NSGs). It includes the renaming and property updates of security rules in the monitorNSG resource, expanding the containerAppEnvironmentNSG with new inbound rules, while leaving existing rules in several other NSGs unchanged. The changes aim to enhance traffic flexibility and introduce specific rules for the container app environment.

Changes

File Path

Change Summary

.azure/modules/vnet/main.bicep

- Renamed security rules in monitorNSG: AllowAzureMonitorInbound → AllowAnyCustomAnyInbound, AllowAzureMonitorOutbound → AllowAnyCustomAnyOutbound - Updated properties for these rules: protocol from 'Tcp' to '', destination port range to '', source and destination address prefixes to '*', and priority from 120 to 100. - Expanded containerAppEnvironmentNSG with new inbound rules for 'container-app', 'container-app-environment', and 'load-balancer', with priorities set from 110 to 140. - Existing rules in defaultNSG, postgresqlNSG, redisNSG, and serviceBusNSG remain unchanged.

Possibly related PRs

• fix(webapi): ensure correct health checks are used in probes #1249: Modifies health probe paths in Bicep templates for Azure container apps, potentially relevant to network security and monitoring.
• fix(service): ensure default credentials work #1306: Adds a managed identity for secure access, relevant to the security aspects of network configurations.
• fix(service): enable health-check for servicebus #1338: Implements health checks for the service bus, aligning with monitoring enhancements discussed.
• fix(azure): set diagnostic setting to allow query perf insights #1422: Adds diagnostic settings for PostgreSQL, improving monitoring and diagnostics in Azure resources.
• fix(azure): ensure postgres configuration run in sequence #1448: Ensures correct sequence of PostgreSQL configuration, indirectly relating to network security configurations.
• feat(azure): create azure monitor workspace #1485: Introduces an Azure Monitor workspace, enhancing monitoring capabilities, a focus of the main PR.

Suggested reviewers

• oskogstad
• MagnusSandgren

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud