fix(infrastructure): use correct networking for servicebus #1320
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Bicep module for provisioning an Azure Service Bus namespace. Key changes include the addition of a private endpoint resource with a unique name, updated properties for the private endpoint, and modifications to the private DNS zone module. The DNS zone's default domain has been changed, and a new module for a private DNS zone group has been added, enhancing secure connectivity and DNS resolution for the Service Bus namespace. Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- .azure/modules/serviceBus/main.bicep (1 hunks)
🧰 Additional context used
🔇 Additional comments (3)
.azure/modules/serviceBus/main.bicep (3)
48-49: Variable definition for private endpoint name is appropriateThe private endpoint name is set using
uniqueResourceNamewith a max length of 80, adhering to Azure naming constraints.
75-75: Configuration of the private DNS zone is appropriateThe name and default domain for the private DNS zone module are correctly set for the Service Bus.
Also applies to: 78-78
51-69:⚠️ Potential issueVerify the API version and the use of
customNetworkInterfaceNameThe resource
Microsoft.Network/privateEndpointsis using API version2023-11-01, which may not be valid or available yet. Additionally, the propertycustomNetworkInterfaceNameat line 66 may not be supported in the current API versions of this resource type.Please verify the API version and confirm whether
customNetworkInterfaceNameis a valid property. You might need to update the API version to a currently supported API version or adjust the code accordingly.
🤖 I have created a release *beep* *boop* --- ## [1.26.0](v1.25.0...v1.26.0) (2024-10-22) ### Features * Add masstransit outbox system ([#1277](#1277)) ([bc04860](bc04860)) ### Bug Fixes * **infrastructure:** use correct networking for servicebus ([#1320](#1320)) ([4fb42bb](4fb42bb)) * Return distinct actions in GetAlinnActions ([#1298](#1298)) ([49948b2](49948b2)) * Upgraded Altinn.ApiClients.Maskinporten, specify TokenExchangeEnvironment ([#1328](#1328)) ([5156799](5156799)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
Service bus resolved the network in the same way as for Redis, so refactoring to do the same. Creating a new dnszone with the proper naming + a dnsgroup
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)Summary by CodeRabbit
New Features
Improvements