Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enduser dialog list endpoint times out on large datasets #1706

Open
knuhau opened this issue Jan 17, 2025 · 2 comments
Open

Enduser dialog list endpoint times out on large datasets #1706

knuhau opened this issue Jan 17, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@knuhau
Copy link
Collaborator

knuhau commented Jan 17, 2025

Description

Enduser dialog list endpoint times out on large datasets

Reproduction

Run /api/v1/enduser/dialogs?Party=urn:altinn:person:identifier-no:14886498226 against YT01

Expected behavior

Return the dialogs belonging to the indicated party

Actual behavior

Timeout, 500 error returned

Additional information

If there is additional context that is relevant to include.

@knuhau knuhau added the bug Something isn't working label Jan 17, 2025
@knuhau knuhau moved this from New issues to Doing in Dialogporten / Arbeidsflate - NY Jan 17, 2025
knuhau added a commit that referenced this issue Jan 18, 2025
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->
Removed .AsSingleQuery from EndUser Search query.

Tested locally with 50 million dialogs. Results show that the removal of
.AsSingleQuery() brings Enduser Search query performance up to par with
that of ServiceOwner Search. We should seek further improvements as
well, as query scaling seems to be an issue.

## Related Issue(s)

- #1706 

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@oskogstad oskogstad moved this from Doing to Testing in Dialogporten / Arbeidsflate - NY Jan 20, 2025
@LeifHelstad
Copy link

Test

Test av denne skjer implisitt via ytelsestest. Avventer testresultater fra Dagfinn fra ytelsestest.

@LeifHelstad
Copy link

Testresultater

Basert på vedlagt dialog anser jeg denne buggen rom rettet, med testet og fungerende løsning.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Testing
Development

No branches or pull requests

3 participants