Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: create dialog tests tries to open non-existent enduser tokens file #1402

Closed
Tracked by #1326
dagfinno opened this issue Nov 6, 2024 · 0 comments
Closed
Tracked by #1326
Assignees

Comments

@dagfinno
Copy link
Collaborator

dagfinno commented Nov 6, 2024

readTestdata.js always tries to read all testdata-files, also the ones not created and not needed for the test (create dialogs does not need enduser tokens)

@dagfinno dagfinno self-assigned this Nov 6, 2024
dagfinno added a commit that referenced this issue Nov 6, 2024
return an empty array if testdatafile not found, check for empty
testdata in k6 tests

<!--- Provide a general summary of your changes in the Title above -->

## Description



## Related Issue(s)

- #1402 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced error handling in various performance testing scripts to
ensure required data arrays are populated before execution.
- Added a new function for reading and parsing CSV files, improving
error handling during file operations.

- **Bug Fixes**
- Enhanced robustness of performance tests by preventing execution with
empty datasets, which could lead to runtime errors.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@dagfinno dagfinno closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant