Skip to content

Commit

Permalink
chore(slacknotifier): remove health checks from slack alerts (#1269)
Browse files Browse the repository at this point in the history
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

We are getting spammed by health-check alerts in Slack. For now these
are just probes that Kubernetes should handle the error of internally.

## Related Issue(s)

- #1261

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new parameter for improved configuration of the Slack
Notifier function app.
- Enhanced security with a system-assigned identity for the function
app.
	- Added a new module for managing application settings seamlessly.
- Implemented an exception alert rule to monitor and notify the
development team of issues.

- **Improvements**
- Enhanced resource management and monitoring capabilities for better
operational efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
arealmaas authored Oct 11, 2024
1 parent 8f70039 commit 18d8d07
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .azure/modules/functionApp/slackNotifier.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ var query = '''
| where not(customDimensions.['Service Type'] == 'API Management')),
(traces
| where severityLevel >= 3 or (severityLevel >= 2 and customDimensions.SourceContext startswith "Digdir"))
| where operation_Name !startswith "GET /health/"
| summarize Count = count()
by
Environment = tostring(customDimensions.AspNetCoreEnvironment),
Expand Down

0 comments on commit 18d8d07

Please sign in to comment.