Skip to content

Commit

Permalink
ci: avoid failing on warnings from deployment (#421)
Browse files Browse the repository at this point in the history
<img width="888" alt="image"
src="https://github.com/digdir/dialogporten/assets/1777366/70c6fabb-8d0e-4376-b3b5-e744d6e58244">

Deployments are failing because of warnings about Bicep cli upgrades.
That's a tad too harsh.. But there doesn't seem to be a way to disable
just those types of warnings so we rather skip failing on warnings. Need
to add a different build step to catch these warning instead. Like a
validation deployment or something similar.

Azure/arm-deploy#126
  • Loading branch information
arealmaas authored Feb 7, 2024
1 parent a5cb137 commit 07d1983
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/action-deploy-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
deploymentMode: Incremental
deploymentName: "dp-be-${{ inputs.environment }}-web-api-migration-job-${{ inputs.gitShortSha }}"
region: ${{ inputs.region }}
failOnStdErr: true
failOnStdErr: false
additionalArguments: "${{inputs.dryRun && '--what-if'}}"
parameters: ./.azure/applications/web-api-migration-job/${{ inputs.environment }}.bicepparam

Expand Down Expand Up @@ -156,7 +156,7 @@ jobs:
deploymentMode: Incremental
deploymentName: dp-be-${{ inputs.environment }}-${{ matrix.name }}-${{ inputs.gitShortSha }}
region: ${{ inputs.region }}
failOnStdErr: true
failOnStdErr: false
additionalArguments: "${{inputs.dryRun && '--what-if'}}"
parameters: ./.azure/applications/${{ matrix.name }}/${{ inputs.environment }}.bicepparam

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/action-deploy-infra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
deploymentMode: Incremental
deploymentName: dp-be-${{ inputs.environment }}-${{ inputs.gitShortSha }}
region: ${{ inputs.region }}
failOnStdErr: true
failOnStdErr: false
additionalArguments: "${{ inputs.dryRun && '--what-if' }}"
parameters: ./.azure/infrastructure/${{ inputs.environment }}.bicepparam

Expand Down

0 comments on commit 07d1983

Please sign in to comment.