Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve observability for load balancer #14003

Merged
merged 20 commits into from
Nov 8, 2024
Merged

Conversation

sduranc
Copy link
Collaborator

@sduranc sduranc commented Nov 7, 2024

Description

  • It sends a trace from the deployment pipeline to our centralized grafana
  • Will generate metrics from endpoints that nginx serves

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sduranc sduranc changed the title Feature/trace deploy feat: improve observability for load balancer Nov 7, 2024
@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Nov 7, 2024
@sduranc sduranc requested a review from mirkoSekulic November 7, 2024 10:11
@sduranc sduranc force-pushed the feature/trace-deploy branch from 21e07f3 to f4c97d3 Compare November 7, 2024 10:26
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (22337dc) to head (c9881e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14003   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files        1740     1740           
  Lines       22815    22815           
  Branches     2670     2670           
=======================================
  Hits        21722    21722           
  Misses        847      847           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sduranc sduranc force-pushed the feature/trace-deploy branch from f4c97d3 to c9881e9 Compare November 8, 2024 08:46
@sduranc sduranc added the skip-manual-testing PRs that do not need to be tested manually label Nov 8, 2024
@sduranc sduranc merged commit eab5110 into main Nov 8, 2024
10 checks passed
@sduranc sduranc deleted the feature/trace-deploy branch November 8, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants