Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added option to disable cursor/hover in css #13826

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

Konrad-Simso
Copy link
Contributor

Description

Added new prop disableRightHandle to StudioResizableLayoutHandle for components which don't need to be resizable, but collapsable and interact with other resizable components. The component selector is one of these cases.

And reordered props for StudioResizableLayoutElement to match the order of extracted props.

Before:
https://github.com/user-attachments/assets/7f655140-c82e-43fa-bd1d-13d2fe78b66b

After:
https://github.com/user-attachments/assets/3a3cc657-db8d-4623-ac5d-a3e60a33fc2e

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@Konrad-Simso Konrad-Simso added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain2 skip-documentation Issues where updating documentation is not relevant labels Oct 18, 2024
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 18, 2024
@Jondyr Jondyr self-assigned this Oct 21, 2024
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok in dev

@JamalAlabdullah JamalAlabdullah removed their assignment Oct 22, 2024
@JamalAlabdullah JamalAlabdullah merged commit 420a7d8 into main Oct 22, 2024
8 checks passed
@JamalAlabdullah JamalAlabdullah deleted the fix/update-studioResizableLayoutHandle branch October 22, 2024 08:02
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.30%. Comparing base (72389f8) to head (f7cce80).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ableLayoutElement/StudioResizableLayoutElement.tsx 0.00% 1 Missing ⚠️
...izableLayoutHandle/StudioResizableLayoutHandle.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13826      +/-   ##
==========================================
- Coverage   95.30%   95.30%   -0.01%     
==========================================
  Files        1652     1652              
  Lines       21978    21980       +2     
  Branches     2583     2585       +2     
==========================================
+ Hits        20946    20947       +1     
  Misses        787      787              
- Partials      245      246       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants