Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign correct terms for org and sub unit in access control #13824

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Oct 18, 2024

Description

  • assign correct terms for org and sub unit in access control
  • align helpText icon with tabTitle by removing css since tabTitle includes spacing-prop and helpText includes placement='top' prop

With change:
Skjermbilde 2024-10-18 kl  14 24 23

Before change:
Skjermbilde 2024-10-18 kl  14 26 06

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (4d92115) to head (97ef226).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13824   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files        1644     1644           
  Lines       21929    21929           
  Branches     2580     2580           
=======================================
  Hits        20897    20897           
  Misses        787      787           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok in dev

@JamalAlabdullah JamalAlabdullah merged commit 5c1e97e into main Oct 22, 2024
6 of 7 checks passed
@JamalAlabdullah JamalAlabdullah deleted the fix/access-control-role-names branch October 22, 2024 08:06
@JamalAlabdullah JamalAlabdullah removed their assignment Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants