Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add StudioFieldset component #13814

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat: Add StudioFieldset component #13814

merged 3 commits into from
Oct 21, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Oct 17, 2024

Description

Added a StudioFieldset component based on Fieldset from The Design System.

Related Issue

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (a12dd61) to head (47b13e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13814   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files        1650     1652    +2     
  Lines       21972    21978    +6     
  Branches     2583     2583           
=======================================
+ Hits        20940    20946    +6     
  Misses        787      787           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng changed the title Add StudioFieldset component feat: Add StudioFieldset component Oct 18, 2024
@TomasEng TomasEng marked this pull request as ready for review October 21, 2024 06:54
@TomasEng TomasEng added skip-releasenotes Issues that do not make sense to list in our release notes skip-manual-testing PRs that do not need to be tested manually skip-documentation Issues where updating documentation is not relevant team/studio-domain1 labels Oct 21, 2024
@Konrad-Simso Konrad-Simso self-assigned this Oct 21, 2024
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@Konrad-Simso Konrad-Simso merged commit 72389f8 into main Oct 21, 2024
9 checks passed
@Konrad-Simso Konrad-Simso deleted the add-fieldset-component branch October 21, 2024 12:11
@Konrad-Simso Konrad-Simso removed their assignment Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants