Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: adding more space to app-preview content #13790

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 15, 2024

Description

  • adding some style to add more space on the preview page
    image

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 added frontend team/studio-domain2 skip-manual-testing PRs that do not need to be tested manually labels Oct 15, 2024
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (b8d6903) to head (bdd7c34).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13790   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files        1624     1624           
  Lines       21817    21817           
  Branches     2572     2572           
=======================================
  Hits        20634    20634           
  Misses        940      940           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. label Oct 15, 2024
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution! 😎 Only one comment

frontend/app-preview/src/views/LandingPage.module.css Outdated Show resolved Hide resolved
@wrt95 wrt95 requested a review from standeren October 16, 2024 06:11
@wrt95 wrt95 merged commit 351030a into main Oct 16, 2024
7 checks passed
@wrt95 wrt95 deleted the adding-more-space-on-preview-page branch October 16, 2024 06:17
@wrt95 wrt95 self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants