Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implementing support for full config of subform component #13782

Merged
merged 9 commits into from
Oct 18, 2024
Merged

feat: Implementing support for full config of subform component #13782

merged 9 commits into from
Oct 18, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 14, 2024 •
edited
Loading

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 14, 2024
@wrt95 wrt95 linked an issue Oct 14, 2024 that may be closed by this pull request
Add tableColumns config #13655
Closed
@wrt95 wrt95 removed a link to an issue Oct 14, 2024
Add tableColumns config #13655
Closed
@wrt95 wrt95 linked an issue Oct 14, 2024 that may be closed by this pull request
Support full configuration of SubForm component #13476
Closed
4 tasks
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (57f01e1) to head (e4c3af6).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13782      +/-   ##
==========================================
+ Coverage   95.27%   95.28%   +0.01%     
==========================================
  Files        1635     1641       +6     
  Lines       21828    21881      +53     
  Branches     2567     2572       +5     
==========================================
+ Hits        20796    20849      +53     
  Misses        787      787              
  Partials      245      245

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jondyr
Jondyr requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

Small nitpick/question:

frontend/packages/ux-editor/src/components/Properties/Text.tsx Outdated Show resolved Hide resolved
@wrt95 wrt95 requested a review from Jondyr October 16, 2024 11:09
@wrt95 wrt95 mentioned this pull request Oct 16, 2024
Open
11 tasks
@Jondyr Jondyr mentioned this pull request Oct 17, 2024
Open
4 tasks
@lassopicasso lassopicasso merged commit 4d92115 into main Oct 18, 2024
23 of 24 checks passed
@lassopicasso lassopicasso deleted the 13476-support-full-config-subform-component branch October 18, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jondyr Jondyr Jondyr approved these changes

@lassopicasso lassopicasso lassopicasso approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support full configuration of SubForm component
3 participants
@wrt95 @Jondyr @lassopicasso