Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: "Upload codelist" functionality in component config #13763

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat: "Upload codelist" functionality in component config #13763

wants to merge 43 commits into from
+421 −149

Commits on Oct 8, 2024

  1. Fix link in codelist config.

    @Konrad-Simso
    Konrad-Simso committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4b20b88 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Upload button added.

    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    89a22f2 View commit details
    Browse the repository at this point in the history

  2. Edit language and fix typing.

    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f627d58 View commit details
    Browse the repository at this point in the history

  3. Fix linting, rename variable and allow trailing commas, it gets fixed… 

    … in AltinnAppGitRepository.
    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ce088e4 View commit details
    Browse the repository at this point in the history

  4. Rename useValidateFileName.ts to validateFileNameUtils.ts 

    Added tests for Utils file.
    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9cc37a3 View commit details
    Browse the repository at this point in the history

  5. Add test for useAddOptionMutation.ts

    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9a23d27 View commit details
    Browse the repository at this point in the history

  6. Add tests for EditCodeList.tsx and remove a toast as it's not correct… 

    … with current logic
    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e199eaf View commit details
    Browse the repository at this point in the history

  7. Edit tests and remove unused imports

    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    73e8b3b View commit details
    Browse the repository at this point in the history

  8. Rename hook to use react-hook rules. 

    Move variable in tests
    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    627433d View commit details
    Browse the repository at this point in the history

  9. Edit filename again

    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1b5bb7a View commit details
    Browse the repository at this point in the history

  10. Render hook correctly in test file.

    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    da0bb76 View commit details
    Browse the repository at this point in the history

  11. Fix whitespaces in backend for linting.

    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d9542a1 View commit details
    Browse the repository at this point in the history

  12. Fixing spacing

    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ac92608 View commit details
    Browse the repository at this point in the history

  13. Move file out of Utils folder, since it's a React hook and not a util… 

    …s function.
    @Konrad-Simso
    Konrad-Simso committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f230629 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Endringer fra review.

    @Konrad-Simso
    Konrad-Simso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    efd12b8 View commit details
    Browse the repository at this point in the history

  2. Refactor useValidateFileName into smaller utils functions and move re… 

    …act hook into EditCodeList.tsx
    @Konrad-Simso
    Konrad-Simso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    541efa4 View commit details
    Browse the repository at this point in the history

  3. - Rename function in validateFileNameUtils.ts 

    - add try catch logic in backend to return correct response to frontend.
- Edit validation logic in frontend for valid file name.
- Select uploaded file on success
    @Konrad-Simso
    Konrad-Simso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1fb11bf View commit details
    Browse the repository at this point in the history

  4. - Add check for when FormField should be visible. 

    - try catch all exceptions and return error message.
- Validation for options after being deserialized.
- Rename in queriesMock.ts.
    @Konrad-Simso
    Konrad-Simso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bbc4c79 View commit details
    Browse the repository at this point in the history

  5. Remove unused import.

    @Konrad-Simso
    Konrad-Simso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b24128c View commit details
    Browse the repository at this point in the history

  6. - Less generic catch. 

    - Reformat foreach and if into where statement.
    @Konrad-Simso
    Konrad-Simso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6819cfa View commit details
    Browse the repository at this point in the history

  7. Remove unused imports again

    @Konrad-Simso
    Konrad-Simso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3308902 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Edit styling 

    - Adjust padding on link
- Edit nativeSelect size to small.
    @Konrad-Simso
    Konrad-Simso committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    735a0a1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/codelist-configuration

    @Konrad-Simso
    Konrad-Simso committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1af9611 View commit details
    Browse the repository at this point in the history

  3. Remove a test and fix 2 tests. 

    - Removed test as the content/alert has been removed in a prior commit.
- Removed test-id from tests as it also has been removed from the current solution.
    @Konrad-Simso
    Konrad-Simso committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    155196c View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Edit test and replace forEach with for of loops for iterator object.

    @Konrad-Simso
    Konrad-Simso committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2395cec View commit details
    Browse the repository at this point in the history

  2. Remove unused parameter, extract filename from File

    @Konrad-Simso
    Konrad-Simso committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ae5ccbf View commit details
    Browse the repository at this point in the history

  3. Changes from 2nd review: 

    - Refactor EditCodeList.tsx
- Edit Language
- Rename useAddOptionMutation.test.ts -> useAddOptionListMutation.test.ts
    @Konrad-Simso
    Konrad-Simso committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    06087e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. fixed typing of props, and changed an error message.

    @Konrad-Simso
    Konrad-Simso committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8640803 View commit details
    Browse the repository at this point in the history

  2. Simplify file uploader component

    @TomasEng
    TomasEng committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    fd06550 View commit details
    Browse the repository at this point in the history

  3. Update file name

    @TomasEng
    TomasEng committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9a603ca View commit details
    Browse the repository at this point in the history

  4. Update reference to updated file name

    @TomasEng
    TomasEng committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2b5218a View commit details
    Browse the repository at this point in the history

  5. Edit import statement

    @Konrad-Simso
    Konrad-Simso committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6f2b3a0 View commit details
    Browse the repository at this point in the history

  6. Updated FileUploaderWithValidation.tsx 

    File cannot be falsy as `StudioFileUploader.tsx` has a check before running onSubmit.
    @Konrad-Simso
    Konrad-Simso committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1f7ae0a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'simplify-file-uploader' into feature/codelist-configura… 

    …tion
    @Konrad-Simso
    Konrad-Simso committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9182ce8 View commit details
    Browse the repository at this point in the history

  8. Refactoring

    @Konrad-Simso
    Konrad-Simso committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    55609b0 View commit details
    Browse the repository at this point in the history

  9. Update tests

    @Konrad-Simso
    Konrad-Simso committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a594d40 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'main' into feature/codelist-configuration

    @TomasEng
    TomasEng authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7ae920d View commit details
    Browse the repository at this point in the history

  2. Updates from 3rd review

    @Konrad-Simso
    Konrad-Simso committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1a05b9e View commit details
    Browse the repository at this point in the history

  3. Update nb.json and edit texts for tests.

    @Konrad-Simso
    Konrad-Simso committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    388d011 View commit details
    Browse the repository at this point in the history

  4. Update test

    @Konrad-Simso
    Konrad-Simso committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    34cbb40 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Updates from testing: 

    - Added a more specific error message when upload fails.
    @Konrad-Simso
    Konrad-Simso committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c0fa350 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/codelist-configuration

    @ErlingHauan
    ErlingHauan authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4aa4506 View commit details
    Browse the repository at this point in the history

  3. Fix type error

    @ErlingHauan
    ErlingHauan committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a853e5f View commit details
    Browse the repository at this point in the history