Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-library): Basic setup for content library #13636

Merged
merged 30 commits into from
Oct 4, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Sep 25, 2024

Description

This PR introduces the initial setup for the Content Library, which is designed to standardize the handling of shared resources like code lists, images, and other assets across multiple React applications.

Changes in this PR:

  • Initial implementation of ContentLibraryImpl:
    • Predefined pages (root, codeList) are set up but not designed.
    • Consumers can provide configuration for these pages through their API, which will be rendered using the getContentResourceLibrary() method.
    • The library is designed to be type-safe and reusable, ensuring consistency across projects.
    • The library has navigation in place technically and can navigate through query-params.

What's next:

  • Navigation & Design:

    • The current setup does not include design of navigation. But the navigation code to be able to navigate is implemented.
  • Action interfaces:

    • The library will need to define interfaces for key actions (add, delete, update) as callbacks to the consumer.
      • This will be done in a separate PR to keep the scope of changes manageable and focused.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates labels Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (23bbdfe) to head (97f1048).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13636      +/-   ##
==========================================
+ Coverage   94.36%   94.38%   +0.01%     
==========================================
  Files        1552     1560       +8     
  Lines       21117    21176      +59     
  Branches     2525     2529       +4     
==========================================
+ Hits        19927    19986      +59     
  Misses        946      946              
  Partials      244      244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid changed the title feat(ContentLibrary): Basic setup for content resource library feat(content-library): Basic setup for content resource library Sep 25, 2024
@framitdavid framitdavid marked this pull request as ready for review September 25, 2024 12:43
@framitdavid framitdavid linked an issue Sep 25, 2024 that may be closed by this pull request
@framitdavid framitdavid linked an issue Sep 25, 2024 that may be closed by this pull request
@framitdavid framitdavid changed the title feat(content-library): Basic setup for content resource library feat(content-library): Basic setup for content library Sep 25, 2024
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig fint skall for den nye pakken! Det er bare noen småting som jeg lurer på.

@framitdavid framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Oct 4, 2024
@framitdavid framitdavid merged commit 85a8c66 into main Oct 4, 2024
4 checks passed
@framitdavid framitdavid deleted the feat/contentLibaryPartOne branch October 4, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Used for issues or pull requests that are dependency updates skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement basic structure for content library in Studio apps
3 participants