Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 495: Add default values for query builder inside connection settings #567

Merged
merged 17 commits into from
Jun 18, 2024

Conversation

lunaticusgreen
Copy link
Collaborator

@lunaticusgreen lunaticusgreen commented May 27, 2024

fix #495

@Slach Slach self-requested a review May 29, 2024 16:40
@antip00
Copy link
Collaborator

antip00 commented May 31, 2024

Issues:

  • Can't create new datasource, save and test button returns nothing
    Screenshot from 2024-05-31 16-20-53
    Screenshot from 2024-05-31 16-21-09

  • I think we need to move default database to other section
    Screenshot from 2024-05-31 16-23-29

@Slach Slach changed the title Issue 495: Add default data selection Issue 495: Add default values for query builder inside connection settings Jun 3, 2024
@lunaticusgreen
Copy link
Collaborator Author

@antip00 Thank you! both problems are fixed

src/datasource/adhoc.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
src/datasource/sql-query/sql-query-macros.ts Outdated Show resolved Hide resolved
src/datasource/sql-query/sql-query-macros.ts Outdated Show resolved Hide resolved
src/datasource/sql-query/sql-query-macros.ts Outdated Show resolved Hide resolved
src/datasource/sql-query/sql-query-macros.ts Outdated Show resolved Hide resolved
src/views/QueryEditor/QueryEditor.tsx Outdated Show resolved Hide resolved
@Slach
Copy link
Collaborator

Slach commented Jun 14, 2024

could run git pull origin master?

@Slach
Copy link
Collaborator

Slach commented Jun 18, 2024

@lunaticusgreen
image

https://github.com/Altinity/clickhouse-grafana/actions/runs/9567400079/job/26375045064?pr=567
test failed
"Save and Test" button return nothing, expect error, look to screenshot

@Slach Slach merged commit fc29dbe into master Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants