Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 506: Proper parsing for WHERE field IN ['item1', 'item2'] added #536

Merged
merged 5 commits into from
Apr 27, 2024
Merged

Issue 506: Proper parsing for WHERE field IN ['item1', 'item2'] added #536

merged 5 commits into from
Apr 27, 2024

Conversation

lunaticusgreen
Copy link
Collaborator

@lunaticusgreen lunaticusgreen commented Apr 14, 2024 •
edited by Slach
Loading

fix #506

@lunaticusgreen lunaticusgreen changed the title Issue 506: Proper parsing for WHERE field IN ['item1', 'item2'] formate added Issue 506: Proper parsing for WHERE field IN ['item1', 'item2'] added Apr 14, 2024
@lunaticusgreen
Copy link
Collaborator Author

@Slach I've seen failing test, I'll fix regexp so it worked properly for all scenarios

Slach
Slach requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add test which will cover this logic?
and we need also change golang part to provide the same logic in alerts

src/datasource/scanner/scanner.ts Show resolved Hide resolved
src/datasource/scanner/scanner.ts Show resolved Hide resolved
@Slach
Copy link
Collaborator

Slach commented Apr 15, 2024

"AND zone ['City'] = 'Kyiv'",

this is wrong generated SQL it shall be zone['City'] without space before [

@Slach Slach modified the milestone: 3.1.0 Apr 17, 2024
@Slach Slach merged commit 372a2d1 into master Apr 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slach Slach Slach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WHERE field IN ('value1','value2') vs WHERE field IN ['value1','value2'] have side effects
2 participants
@lunaticusgreen @Slach