Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23.3 Backport of #55119 - Fix deadlock in LDAP assigned role update - take 2 #364

Commits on Feb 9, 2024

  1. Merge pull request ClickHouse#55119 from jmaicher/fix/54318/deadlock-…

    …ldap-role-update
    
    Fix deadlock in LDAP assigned role update
    alexey-milovidov authored and Enmk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    55db377 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ClickHouse#56544 from jmaicher/fix/flaky-ldap-inte…

    …gration-test
    
    Fix flaky LDAP integration tests
    alexey-milovidov authored and Enmk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d537e03 View commit details
    Browse the repository at this point in the history
  3. Update cluster.py

    Fixed merge conflict from rebasing
    Enmk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2195b38 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Silly attempt to fix failing test_ldap_external_user_directory/test.p…

    …y::test_role_mapping
    Enmk committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4d6d018 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. 'Fix' the test with sleep(10 minutes 10 seconds)

    Update of assigned roles (`GrantedRoles`) on `User` instance that occurs
    inside `LDAPAccessStorage` doesn't bubble up to `AccessStorate`
    and not broadcasted as an event to `AccessChangesNotifier` event handlers.
    
    Thus `AccessControl` that is held by `Context` never receives an event and
    is never updated, holding old instance of `User` with previous set of roles.
    
    `AccessControl` instances are cached for 600 seconds, so waiting for 600 + 10
    seconds between sessions ensures that when user is logged in again, new
    `AccessControl` instance is created, and proper (updated `User`, with
    updated `GrantedRoles`) is created.
    
    This issue seems to be already fixed in upstream/master,
    but for now we are not going to backport it, just fix the test.
    Enmk committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f5000c1 View commit details
    Browse the repository at this point in the history