Merge pull request ClickHouse#44469 from Avogar/low-card-if

Don't execute and/or/if/multiIf on LowCardinality dictionary
Altinity · Jun 28, 2023 · a3428f0 · a3428f0
1 parent e8e4192
commit a3428f0
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 0 deletions.
diff --git a/src/Functions/FunctionsLogical.h b/src/Functions/FunctionsLogical.h
@@ -164,6 +164,7 @@ class FunctionAnyArityLogical : public IFunction
     ColumnPtr executeShortCircuit(ColumnsWithTypeAndName & arguments, const DataTypePtr & result_type) const;
     bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return false; }
     size_t getNumberOfArguments() const override { return 0; }
+    bool canBeExecutedOnLowCardinalityDictionary() const override { return false; }
 
     bool useDefaultImplementationForNulls() const override { return !Impl::specialImplementationForNulls(); }
 

diff --git a/src/Functions/if.cpp b/src/Functions/if.cpp
@@ -1023,6 +1023,7 @@ class FunctionIf : public FunctionIfBase
     }
     bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return false; }
     ColumnNumbers getArgumentsThatDontImplyNullableReturnType(size_t /*number_of_arguments*/) const override { return {0}; }
+    bool canBeExecutedOnLowCardinalityDictionary() const override { return false; }
 
     /// Get result types by argument types. If the function does not apply to these arguments, throw an exception.
     DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override

diff --git a/src/Functions/multiIf.cpp b/src/Functions/multiIf.cpp
@@ -50,6 +50,7 @@ class FunctionMultiIf final : public FunctionIfBase
     bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return false; }
     size_t getNumberOfArguments() const override { return 0; }
     bool useDefaultImplementationForNulls() const override { return false; }
+    bool canBeExecutedOnLowCardinalityDictionary() const override { return false; }
 
     ColumnNumbers getArgumentsThatDontImplyNullableReturnType(size_t number_of_arguments) const override
     {

diff --git a/tests/queries/0_stateless/02514_if_with_lazy_low_cardinality.reference b/tests/queries/0_stateless/02514_if_with_lazy_low_cardinality.reference
@@ -0,0 +1 @@
+1
diff --git a/tests/queries/0_stateless/02514_if_with_lazy_low_cardinality.sql b/tests/queries/0_stateless/02514_if_with_lazy_low_cardinality.sql
@@ -0,0 +1,5 @@
+create table if not exists t (`arr.key` Array(LowCardinality(String)), `arr.value` Array(LowCardinality(String))) engine = Memory;
+insert into t (`arr.key`, `arr.value`) values (['a'], ['b']);
+select if(true, if(lowerUTF8(arr.key) = 'a', 1, 2), 3) as x from t left array join arr;
+drop table t;
+
diff --git a/tests/queries/0_stateless/02515_and_or_if_multiif_not_return_lc.reference b/tests/queries/0_stateless/02515_and_or_if_multiif_not_return_lc.reference
@@ -0,0 +1,4 @@
+UInt8
+UInt8
+UInt8
+UInt8
diff --git a/tests/queries/0_stateless/02515_and_or_if_multiif_not_return_lc.sql b/tests/queries/0_stateless/02515_and_or_if_multiif_not_return_lc.sql
@@ -0,0 +1,5 @@
+select toTypeName(if(toLowCardinality(number % 2), 1, 2)) from numbers(1);
+select toTypeName(multiIf(toLowCardinality(number % 2), 1, 1, 2, 3)) from numbers(1);
+select toTypeName(toLowCardinality(number % 2) and 2) from numbers(1);
+select toTypeName(toLowCardinality(number % 2) or 2) from numbers(1);
+