forked from tari-project/tari
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch component - improvement #89
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
62 changes: 0 additions & 62 deletions
62
applications/launchpad_v2/src/components/Inputs/Switch/index.tsx
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
applications/launchpad_v2/src/components/Inputs/Switch/types.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
applications/launchpad_v2/src/components/Switch/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
import { animated, useSpring } from 'react-spring' | ||
import { useTheme } from 'styled-components' | ||
|
||
import Text from '../Text' | ||
|
||
import { | ||
LabelText, | ||
SwitchContainer, | ||
SwitchController, | ||
SwitchCircle, | ||
} from './styles' | ||
import { SwitchProps } from './types' | ||
|
||
/** | ||
* Switch input controller | ||
* | ||
* @param {boolean} value - the input value | ||
* @param {string | ReactNode} [leftLabel] - the text or ReactNode element on the left side of the switch. | ||
* @param {string | ReactNode} [rightLabel] - the text or ReactNode element on the right side of the switch. | ||
* @param {(val: boolean) => void} onClick - when the switch is clicked. Returns the new value. | ||
* @param {boolean} [inverted] - use inverted styles | ||
* @param {string} [testId] - the test ID (react-testing/jest) | ||
* | ||
* @example | ||
* <Switch | ||
* leftLabel={<SvgSun width='1.4em' height='1.4em' />} | ||
* rightLabel={'The label text'} | ||
* value={currentTheme === 'dark'} | ||
* onClick={v => dispatch(setTheme(v ? 'dark' : 'light'))} | ||
* /> | ||
*/ | ||
const Switch = ({ | ||
value, | ||
leftLabel, | ||
rightLabel, | ||
onClick, | ||
inverted, | ||
testId, | ||
}: SwitchProps) => { | ||
const theme = useTheme() | ||
|
||
const themeStyle = inverted ? theme.inverted : theme | ||
|
||
const circleAnim = useSpring({ | ||
left: value ? 10 : -1, | ||
}) | ||
|
||
const labelColorAnim = useSpring({ | ||
color: themeStyle.primary, | ||
}) | ||
|
||
const controllerAnim = useSpring({ | ||
background: value ? themeStyle.accent : 'transparent', | ||
}) | ||
|
||
const leftLabelEl = | ||
leftLabel && typeof leftLabel === 'string' ? ( | ||
<Text as={animated.span} type='smallMedium' style={{ ...labelColorAnim }}> | ||
{leftLabel} | ||
</Text> | ||
) : ( | ||
leftLabel | ||
) | ||
const rightLabelEl = | ||
rightLabel && typeof rightLabel === 'string' ? ( | ||
<Text as={animated.span} type='smallMedium' style={{ ...labelColorAnim }}> | ||
{rightLabel} | ||
</Text> | ||
) : ( | ||
rightLabel | ||
) | ||
|
||
return ( | ||
<SwitchContainer | ||
onClick={() => onClick && onClick(!value)} | ||
data-testid={testId || 'switch-input-cmp'} | ||
> | ||
{leftLabelEl ? ( | ||
<LabelText | ||
style={{ | ||
marginRight: 12, | ||
...labelColorAnim, | ||
}} | ||
> | ||
{leftLabelEl} | ||
</LabelText> | ||
) : null} | ||
|
||
<SwitchController style={{ ...controllerAnim }}> | ||
<SwitchCircle style={{ ...circleAnim }} /> | ||
</SwitchController> | ||
|
||
{rightLabelEl ? ( | ||
<LabelText | ||
style={{ | ||
marginLeft: 12, | ||
...labelColorAnim, | ||
}} | ||
> | ||
{rightLabelEl} | ||
</LabelText> | ||
) : null} | ||
</SwitchContainer> | ||
) | ||
} | ||
|
||
export default Switch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { ReactNode } from 'react' | ||
|
||
export interface SwitchProps { | ||
value: boolean | ||
leftLabel?: string | ReactNode | ||
rightLabel?: string | ReactNode | ||
onClick: (val: boolean) => void | ||
inverted?: boolean | ||
testId?: string | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 18 additions & 1 deletion
19
applications/launchpad_v2/src/containers/MiningContainer/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference here between this and
useTheme
fromstyled-components
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
useTheme
provides the configuration whileuseSelector(selectTheme)
says which theme is active (light
ordark
).To give a better context:
In the
App.tsx
:... we also use the selector. It is used there to switch between themes. So:
ThemeProvider
.So then in the code, we use use
useTheme
to get the style configuration (colors etc.)But to know which theme is active, we need to read it from Redux with
useSelector(selectTheme)