-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(primitive): add text component #77
feat(primitive): add text component #77
Conversation
refer issue #74
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment about global styles
just a question - so the idea is that whenever I'm rendering text (e.g. when I'm showing a label above a select component), I should use component, right? if so, I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly what we discussed, minor comments about linting and fragments, otherwise looks good to go after fragment change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
refer issue #74
Description
Add generic Text component
Motivation and Context
Primitive Text component connected to fonts/typography
How Has This Been Tested?
Unit tests will be added in future PR when testing structure is set up.