Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitive): add text component #77

Merged
merged 6 commits into from
Apr 21, 2022

Conversation

corquaid
Copy link

refer issue #74

Description

Add generic Text component

Motivation and Context

Primitive Text component connected to fonts/typography

How Has This Been Tested?

Unit tests will be added in future PR when testing structure is set up.

Screenshot 2022-04-20 at 10 11 05

Copy link

@tarnas14 tarnas14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about global styles

applications/launchpad_v2/src/components/Text/index.tsx Outdated Show resolved Hide resolved
@tarnas14
Copy link

tarnas14 commented Apr 20, 2022

just a question - so the idea is that whenever I'm rendering text (e.g. when I'm showing a label above a select component), I should use component, right?

if so, I think type should be optional and have a nice default value (I guess defaultMedium ? )

@corquaid corquaid requested a review from tarnas14 April 20, 2022 12:23
tarnas14
tarnas14 previously approved these changes Apr 20, 2022
Copy link

@tarnas14 tarnas14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly what we discussed, minor comments about linting and fragments, otherwise looks good to go after fragment change

tarnas14
tarnas14 previously approved these changes Apr 21, 2022
Copy link

@tarnas14 tarnas14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

Copy link

@tomaszantas tomaszantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corquaid corquaid merged commit 675526f into launchpad_such_wow Apr 21, 2022
@corquaid corquaid deleted the launchpad/feature/text-component branch April 21, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants