Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "global serializer cache" #78

Merged
merged 1 commit into from
Feb 10, 2016

Conversation

ryochiji
Copy link
Contributor

@ryochiji ryochiji commented Feb 6, 2016

Reverts #72

@ryochiji
Copy link
Contributor Author

@aleontiev - Can we merge this? I realized global serializer caching just isn't going to work because context is dynamic, but DRF caches it at the instance level. So when serializers are re-used across requests, serializers could be using the wrong cached context.

ryochiji added a commit that referenced this pull request Feb 10, 2016
…izer-cache

Revert "global serializer cache"
@ryochiji ryochiji merged commit 0825001 into master Feb 10, 2016
@aleontiev
Copy link
Collaborator

👍, sorry about the delay

@atzannes atzannes deleted the revert-72-feature/global-serializer-cache branch August 24, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants