auto-generate link objects for non-sideloaded relations #36
Conversation
| @@ -242,6 +269,12 @@ def to_representation(self, instance): | |||
| WithDynamicSerializerMixin, | |||
| self).to_representation(instance) | |||
|
|
|||
| if getattr(settings, 'DYNAMIC_REST', {}).get('ENABLE_LINKS', True): | |||
There was a problem hiding this comment.
Does this mean sideloaded records will also have link fields for their relationships?
There was a problem hiding this comment.
get_link_fields() above will return a list that excludes sideloaded fields (see here).
There was a problem hiding this comment.
Yup, that makes sense. I was wondering if a sideloaded record with a relationship that is not itself sideload would also include links, e.g:
GET /users/?include[]=location.
{
"user": {
"location": 1,
},
"locations": [{
"id": 1,
"links": {
"cats": "/locations/1/cats"
}
}]
}
This seems like useful behavior, and I suppose Ember Data does the link extraction at the record/serializer level rather than the response/views level (not really sure though)
There was a problem hiding this comment.
Yep, links will be added to any object that gets serialized by a DREST serializer, whether it's at the top level, sideloaded, or embedded.
|
+1, minor comment |
auto-generate link objects for non-sideloaded relations
Automatically generate links for non-sideloaded relations. By default, links point to the new relation endpoints, but can be overridden by setting a
linkattribute on DynamicRelationField (which can be a string or function which returns a URL).