Fix metrics when delete non existing page #18618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jja725
force-pushed
the
fix-delete-nonexisting
branch
from
7d60e76
to
71dccbb
Compare
jja725
force-pushed
the
fix-delete-nonexisting
branch
3 times, most recently
from
49c8137
to
729da25
Compare
jja725
force-pushed
the
fix-delete-nonexisting
branch
from
729da25
to
bbcda68
Compare
|
alluxio-bot, merge this please |
|
alluxio-bot, merge this please |
|
post merge LGTM |
|
alluxio-bot, cherry-pick this to master-2.x please |
alluxio-bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
### What changes are proposed in this pull request? Fix metrics when delete non existing page ### Why are the changes needed? When deleting non-existing page we see a abnormal spike in PageAge. Still doesn't know why we have abnormal PageAge but since it's non-existing page we would not able to read it as well so it make sense to not record the age. Also we continue to delete page from page store if we didn't find it in metastore so we avoid inconsistency between pagestore and metastore ### Does this PR introduce any user facing changes? na pr-link: #18618 change-id: cid-7d4803cb2d8c433d3ad077a7bf9e3074d91b3389
|
Auto cherry-pick to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fix metrics when delete non existing page
Why are the changes needed?
When deleting non-existing page we see a abnormal spike in PageAge. Still doesn't know why we have abnormal PageAge but since it's non-existing page we would not able to read it as well so it make sense to not record the age.
Also we continue to delete page from page store if we didn't find it in metastore so we avoid inconsistency between pagestore and metastore
Does this PR introduce any user facing changes?
na