-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the broken PagedDoraWorkerTest #18150
Merged
alluxio-bot
merged 9 commits into
Alluxio:main
from
YichuanSun:UT-PagedDoraWorkerTestFix
Sep 19, 2023
Merged
Fix the broken PagedDoraWorkerTest #18150
alluxio-bot
merged 9 commits into
Alluxio:main
from
YichuanSun:UT-PagedDoraWorkerTestFix
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
YichuanSun
changed the title
Ut paged dora worker test fix
Fix the broken PagedDoraWorkerTest
Sep 14, 2023
Automated checks report:
All checks passed! |
YichuanSun
requested review from
jja725 and
elega
and removed request for
jja725
September 14, 2023 08:09
jiacheliu3
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
elega
approved these changes
Sep 18, 2023
YichuanSun
force-pushed
the
UT-PagedDoraWorkerTestFix
branch
2 times, most recently
from
September 18, 2023 08:26
daaab16
to
06fefa6
Compare
YichuanSun
force-pushed
the
UT-PagedDoraWorkerTestFix
branch
from
September 18, 2023 08:28
06fefa6
to
838893d
Compare
YichuanSun
force-pushed
the
UT-PagedDoraWorkerTestFix
branch
from
September 18, 2023 09:00
bd9504c
to
06fefa6
Compare
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fix the broken PagedDoraWorkerTest.
Why are the changes needed?
The old test is.broken, I just fix it.
Does this PR introduce any user facing changes?
no.