Unmount corrupted folder is case nodeserver restarted #15191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
Binyang2014
changed the title
|
Automated checks report:
All checks passed! |
ssz1997
approved these changes
Mar 28, 2022
|
Thanks @Binyang2014 ! |
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Unmount corrupted folder is case csi-nodeserver restarted
Related to issue #14917
This change just mitigate the issue. If node-server restated, it will try to remount the folder. But user job still can not access data during restarting period.
Just notice these is another solution for this issue #15165. Believe this solution is more robustness and better for critical job. But this solution need more efforts to be mutual for production workload. Maybe at this stage, we can keep the both.
Notice: this change requires k8s version above 1.18
This change not tested yet, we need to kill the nodeserver. After it restarted, check if the mount path is remounted