Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 188 integrate protocols #220

Merged
merged 10 commits into from
Apr 19, 2024
Merged

Conversation

mekhlakapoor
Copy link
Contributor

@mekhlakapoor mekhlakapoor commented Apr 16, 2024

close #188

This PR:

  • adds enum for ProtocolNames in smartsheet
  • adds ProtocolIntegrator class with methods to merge protocol responses with procedures
  • for now, only does the merge if the procedure is a surgical procedure
  • adds upper bound to pydantic version <=2.6.4

@mekhlakapoor mekhlakapoor marked this pull request as draft April 16, 2024 18:38
@mekhlakapoor mekhlakapoor marked this pull request as ready for review April 16, 2024 21:50
@mekhlakapoor mekhlakapoor requested a review from dyf April 17, 2024 08:51
@mekhlakapoor mekhlakapoor merged commit 72a2cdb into main Apr 19, 2024
2 checks passed
@mekhlakapoor mekhlakapoor deleted the feat-188-integrate-protocols branch April 19, 2024 20:50
mekhlakapoor added a commit that referenced this pull request Oct 25, 2024
* protocols mapping and integration

* workaround to avoid multiple smartsheet api calls

* fix surgery protocol mapping, unit tests

* linters

* fixes linters, docstrings

* upper bound for pydantic

* upper bound 2.6.4

* switch order

* pins pydantic version

* feat: reverts changes to endpoint args

---------

Co-authored-by: jtyoung84 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate protocol_id into procedures model
2 participants