Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove endpoint label in title and search with enter #213

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

micahwoodard
Copy link
Contributor

@micahwoodard micahwoodard commented Apr 2, 2024

fixes #208

  • remove endpoint label in title
  • use enter to search
  • display data before message

@micahwoodard
Copy link
Contributor Author

Do we want to remove highlight for metadata that has validation errors?

@helen-m-lin
Copy link
Contributor

Do we want to remove highlight for metadata that has validation errors?

Maybe we should add a check so that certain error codes are red-highlighted. We can probably leave the success ones as is. Looking at these, I think 406 and 300 do not need to be red highlighted, @jtyoung84 what do you think?

class StatusCodes(Enum):
"""Enum class of status codes"""
CONNECTION_ERROR = 503
INTERNAL_SERVER_ERROR = 500
MULTIPLE_RESPONSES = 300
VALID_DATA = 200
DB_RESPONDED = 203
INVALID_DATA = 406
NO_DATA_FOUND = 404
MULTI_STATUS = 207

@jtyoung84
Copy link
Collaborator

Do we want to remove highlight for metadata that has validation errors?

Maybe we should add a check so that certain error codes are red-highlighted. We can probably leave the success ones as is. Looking at these, I think 406 and 300 do not need to be red highlighted, @jtyoung84 what do you think?

class StatusCodes(Enum):
"""Enum class of status codes"""
CONNECTION_ERROR = 503
INTERNAL_SERVER_ERROR = 500
MULTIPLE_RESPONSES = 300
VALID_DATA = 200
DB_RESPONDED = 203
INVALID_DATA = 406
NO_DATA_FOUND = 404
MULTI_STATUS = 207

We probably don't need to highlight them.

@micahwoodard
Copy link
Contributor Author

Okay makes sense to me! Here is a version where if the status code is 406 or 300, the text is just black. Where you thinking of just having the text in black or be in another color like green or darkorange?

@jtyoung84 jtyoung84 merged commit 36ae1ef into main Apr 3, 2024
2 checks passed
@jtyoung84 jtyoung84 deleted the feat-280-improve-search branch April 3, 2024 16:16
mekhlakapoor pushed a commit that referenced this pull request Oct 25, 2024
* feat: remove endpoint label in title and search with enter

* feat: better formatting

* feat: data before message

* feat: remove unnecessary comment

* feat:dont highlight status code 406 or 300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Subjects searchbar UI
3 participants