Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement QC Capsule #18

Open
alexpiet opened this issue Nov 19, 2024 · 5 comments
Open

Implement QC Capsule #18

alexpiet opened this issue Nov 19, 2024 · 5 comments
Assignees

Comments

@alexpiet
Copy link
Collaborator

alexpiet commented Nov 19, 2024

Is there data? (NAN, number of frames)
if <1200frames (=1min), likely a test sessions or alike
Are there NaNs in either the raw FIP data or processed FIP data?

number of ROI (columnN of the CSV) correct?
checking the source CSV (maybe QA) and nwb packaged data

Some metric of SNR.
histgram of raw values to see baseline intensity, fluctuations

Is there saturation ?
if == 65535 (16bit)

Is the trace stable?
histgram of 1st derivative, outlier detection (>% of sliding baseline mean, etc)

Are there dropped frames?
number of frames for 3 ch the same? same as number of sync pulses? (but can be QA-level)

Is there cross-talk between channels?
correlations between fibers/channels but can be tricky as we may be actually measuring highly correlated signals.

Is there bleaching?
histogram of subtracted bleaching?

Is there timing issues? Different channels locked to one another properly.
TBD what would be the best (should be agnostic to specific behavior)

@alexpiet
Copy link
Collaborator Author

alexpiet commented Nov 19, 2024

  • link to QC examples
  • need to specific what the QC capsule should do
    • Read data
    • create evaluate object
    • create metrics
    • store outputs in docdb

@jeromelecoq
Copy link
Collaborator

Ok. So first, you best source of information on this is @dbirman

Here are some useful instructions.
https://aind-data-schema.readthedocs.io/en/latest/quality_control.html

Here is an example QC capsule template : https://github.com/AllenNeuralDynamics/aind-qc-capsule-example/blob/main/code/run_capsule.py

Here is the QC portal that is pulling those metrics real-time (4h delay currently). https://qc.allenneuraldynamics.org/qc_portal_app

@jeromelecoq jeromelecoq assigned alexpiet and hagikent and unassigned jeromelecoq Nov 19, 2024
@jeromelecoq
Copy link
Collaborator

I would recommend you both block one or 2 afternoon of work to get this started.

@rachelstephlee
Copy link
Collaborator

Kenta is still working on this.

By the end of the year, Dan and Kenta will put together a design.

By next year, Dan will help out Kenta to do this.

Jerome said that higher order analysis will be higher priority next year, so the sooner we can wrap this up, the better it will be.

@rachelstephlee
Copy link
Collaborator

@dyf says it should be trivial to add an additional QC (but if we want to update backwards it will take more work).

Jerome thinks success for EOY is:

  • Data collected, processed, tracked, and QC within 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants