Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Quality Control metrics #864

Open
2 tasks done
alexpiet opened this issue Oct 30, 2024 · 12 comments
Open
2 tasks done

Implement Quality Control metrics #864

alexpiet opened this issue Oct 30, 2024 · 12 comments

Comments

@alexpiet
Copy link
Collaborator

alexpiet commented Oct 30, 2024

Keeping a compiled list here

QA (Done before data is collected "assure data will be good")

Cameras

  • Are there dropped frames?
  • Histograms to quantify out-of-focus images

Harp

  • Do boards all share the same sync clock?
  • Harp logs and firmware?

Harp treadmill

  • Encoder captures wheel movement
  • Brake default to 0. Can modify input torque.
  • Torque sensor baseline.

Harp sniff sensor

  • Baseline signal
  • Reads temperature changes.

Harp clock

  • All boards synch to clock
  • Repeater in repeater mode

Harp behavior

  • Sound triggers: # Softcode = # Harp triggers
  • Water triggers: # Softcode = # Harp triggers
  • Sound and water within odor sites.

Harp olfactometer

  • Minimum flow met.
  • Odor valve open -> End valve open > End valve close> Odor valve close.

Harp lick sensor

  • Licks are detected, on off times are realistic.

Speaker

  • Verify the speaker amplitude is correct

QC (Done after data is collected "Control for bad data")

  • Number of licks in the session
  • Histogram of lick response times
  • Double-dipping
  • Number of trials
  • Software: development/correction of bias over past sessions - metric to quantify
  • Behavior: Simple RL index to track behavior improvement
  • session length (in time and trials)
  • trials completed (The proportion of ignored trials throughout a session (may exclude ignored trials at the end of the session)
  • cross talk licking
  • see trends in licking, to asses for lick detection problems
  • Camera illumination, orientation, frame drops

FIP

  • data complete? all csv, all binary data complete?
  • data length correct? all same lenght?
  • ROI looks ok?
  • no obvious artefact? e.g. fiber patch-cable disconnection, movement, etc
  • Implement QC Capsule aind-fip-dff#18

VR foraging

  • Total distance traveled
  • Min and max velocity
  • Session length
  • Minimum sniff cycles
@ellahiltonvano
Copy link

@JeremiahYCohen
Copy link

QA:

  1. Cameras
    o Are there dropped frames?
    o Histograms to quantify out-of-focus images
  2. Harp
    o Do boards all share the same sync clock?
    o Harp logs and firmware?

QC:

  1. Number of licks in the session
  2. Histogram of lick response times
  3. Double-dipping
  4. Number of trials

@hagikent
Copy link
Collaborator

hagikent commented Nov 6, 2024

For FP

QA:
1.data complete? all csv, all binary data complete?
2.data length correct? all same lenght?
3.ROI looks ok?
4.no obvious artefact? e.g. fiber patch-cable disconnection, movement, etc
5.

@alexpiet @hanhou @JeremiahYCohen
How would you see QA to be organized? I can naively picture putting all into one light-weight .py file that generates plots+metrics, and GUI triggers it upon completion of each session?

__
QC: Managed here:
https://github.com/orgs/AllenNeuralDynamics/projects/75/views/1?filterQuery=QC&pane=issue&itemId=86115745
https://github.com/AllenNeuralDynamics/aind-physio-arch/issues/53

@ellahiltonvano
Copy link

ellahiltonvano commented Nov 12, 2024

Hi all, as listed on our action items please comment on this issue and see the related RACI chart (mentioned above in issue 599). Comment on this issue and check off your name on the action items discussion.
@ZhixiaoSu @KanghoonJ @galenlynch @jasonyslee @bwtan-allen @XX-Yin

@galenlynch
Copy link
Contributor

Looks good...

@bwtan-allen
Copy link

QC:

Software: development/correction of bias over past sessions - metric to quantify
Behavior: Simple RL index to track behavior improvement

@alexpiet
Copy link
Collaborator Author

QC -

  • session length
  • trials completed

@tiffanyona
Copy link

tiffanyona commented Nov 18, 2024

QA before data acquisiton, QC after data acquisition (assumes QA was passed)

QA
Harp treadmill

  • Encoder captures wheel movement
  • Brake default to 0. Can modify input torque.
  • Torque sensor baseline.

Harp sniff sensor

  • Baseline signal
  • Reads temperature changes.

Harp clock

  • All boards synch to clock
  • Repeater in repeater mode

Harp behavior

  • Sound triggers: # Softcode = # Harp triggers
  • Water triggers: # Softcode = # Harp triggers
  • Sound and water within odor sites.

Harp olfactometer

  • Minimum flow met.
  • Odor valve open -> End valve open > End valve close> Odor valve close.

Harp lick sensor

  • Licks are detected, on off times are realistic.

QC

  • Total distance traveled
  • Min and max velocity
  • Session length
  • Minimum sniff cycles

@KanghoonJ
Copy link
Contributor

QC

  • The proportion of ignored trials throughout a session (may exclude ignored trials at the end of the session).
  • Total run time

@jasonyslee
Copy link

I haven't run mice yet and can't honestly comment critically.
When I get Force Foraging behavior running I will come back and add QC metrics for that.
So for now... LOOKS GOOD.

@XX-Yin
Copy link
Collaborator

XX-Yin commented Nov 19, 2024

QC:
early licking rate in ITI, delay

@ellahiltonvano
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants