Noah/fix omezarr tile math mistake #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he size of the image layer as a whole. add a super-quick pan to the example app. update the version.
froyo-np
requested review from
TheMooseman,
crispipear and
lanesawyer
and removed request for
crispipear
froyo-np
commented
Dec 2, 2024
| @@ -30,7 +30,7 @@ function visitTilesWithin(idealTilePx: vec2, size: vec2, bounds: box2D, visit: ( | |||
| for (let y = Math.floor(boundsInTiles.minCorner[1]); y < Math.ceil(boundsInTiles.maxCorner[1]); y += 1) { | |||
| // all tiles visited are always within both the bounds, and the image itself | |||
| const lo = Vec2.mul([x, y], idealTilePx); | |||
| const hi = Vec2.add(lo, idealTilePx); | |||
| const hi = Vec2.min(size, Vec2.add(lo, idealTilePx)); | |||
There was a problem hiding this comment.
this is the fix - it limits the visited tiles by the total size of the image. The bug here caused a bunch of math later in the process to be incorrect, because the tiles extended past what was actually possible.
TheMooseman
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Replace this txt describing what kind of technical overlaying code changes were introduced here.
Screenshots
This section is optional if there are no visible changes
PR Checklist
main?