-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ome-zarr slice-view renderer package #34
Conversation
…d space. next, verify it works, then delete all the crud
…ld be complete copy-paste with the examples/dzi demo, so I didn't bother
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple but renders!
Just some general cleanup items with demo location and setting up the package package.json
like the other packages.
packages/omezarr/package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't matching the other packages
. Should be parcel
stuff instead in this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parcel seems incapable of building when importing zarrita - I tried to figure it out, but I lost that fight, which is why the examples package also does not use parcel. I figured since we're feeling good about vite elsewhere, and use it in the examples, I'd just roll with it. I seems to support building libraries/packages just fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turn out I was completely wrong about this - parcel is back in
packages/omezarr/vite.config.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can go away once example piece is moved to examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"compilerOptions": { | ||
"paths": { | ||
"~/*": ["./*"] | ||
}, | ||
"moduleResolution": "Bundler", | ||
"module": "ES2022", | ||
"target": "ES2022", | ||
"lib": ["es2022", "DOM"] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to do it in this PR, I'm just thinking we might want a tsconfig.package.json
file as well to get the common packaging stuff together!
Co-authored-by: Lane Sawyer <[email protected]>
…build in library mode did - nothing else could import it. move furnature around, build a short demo in the examples for omezarr slice viewing. remove unused rotation prop for omezarr tile rendering
…Institute/vis into noah/ome-zarr-slice-viewer
|
||
// find the tiles, in voxels, to request... | ||
const allTiles = getAllTiles([tileSize, tileSize], size); | ||
// TODO: this is a pretty slow, and also somewhat flickery way to do this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO now or later? Is this going to cause similar issues we saw with the dzi viewer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
): VoxelTile[] { | ||
const uv = uvForPlane(plane); | ||
const layer = pickBestScale(dataset, uv, camera.view, camera.screenSize); | ||
// TODO: open the array, look at its chunks, use that size for the size of the tiles I request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO now or later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
later - updated comment!
const uv = uvForPlane(plane); | ||
// TODO (someday) open the array, look at its chunks, use that size for the size of the tiles I request! | ||
|
||
const layer = pickBestScale(dataset, uv, camera.view, camera.screenSize); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for these comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendering is working for me and code looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well commented, working great on Mac and Firefox, this is good to go!
a super-quick renderer for 2D slices of 3-channel RGB images stored in the OME-ZARR format, following the example of the DZI renderer package.
TODO: