Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Multiclamp Commander Settings to .extract_sweep_stim_info() in AibsDataSet #360

Open
kasbaker opened this issue Mar 12, 2020 · 1 comment

Comments

@kasbaker
Copy link
Contributor

kasbaker commented Mar 12, 2020

We need all the settings listed in .register_enabled_names(), which is a method of LabNotebookReader. Additionally, there should be settings for Cp Fast and Cp Slow, which each have a capacitance and time constant associated with them. I could not find these settings in .register_enabled_names(). This issue is related to AllenInstitute/sweep_qc_tool#51

@tmchartrand
Copy link
Collaborator

Just wanted to echo that this is an important feature and it would be great to get @kasbaker 's fixes merged soon.
While the get_notebook_value solution gets part of the way there, I would suggest that at least those values relevant to current clamp sweeps (namely capacitance neutralization) be added to get_sweep_metadata by default as in the original PR. This would allow the features to be accessible from the sweep table and in the output json, to simplify querying across cells/sweeps without actually loading the NWB. I can file a separate PR for this, since I've already been running it on my fork.
Potentially, the longer list of voltage-clamp metadata could be added also, conditional on a check of the sweep's clamp type, which would minimize any performance hit from repeatedly checking for properties that are not present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants