Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding overwrite_config option to build_env_pointnet() and merging 2024 bmtk-workshop opt tutorials #386

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

beaherrera
Copy link

@beaherrera beaherrera commented Oct 21, 2024

  • Adding overwrite_config option to build_env_pointnet(). It returned an error when rebuilding the environment with different config options for the same base_dir. This option was already available for build_env_bionet().
  • Merging optional tutorials from 2024 bmtk-workshop into Additional Tutorials on the bmtk documentation. I also modified the autodocs scripts and pages to update the website.
  • Updated Annual Modeling Software Workshop page:
    • Added the link to the 2024 workshop recordings and the signed-up link for the newsletter.

Added link to 2024 workshop videos and newsletter signup
- Updated format to match main bmtk tutorials
- Fixed typos
- added opt tutorials to ad_tutorials.rst
- fixed bugs for getting opt tutorial notebooks to work with Sphinx
@beaherrera beaherrera changed the title Adding overwrite_config option to build_env_pointnet() and minor documentation update Adding overwrite_config option to build_env_pointnet() and merging 2024 bmtk-workshop opt tutorials Oct 23, 2024
@kaeldai
Copy link
Collaborator

kaeldai commented Oct 25, 2024

Hi @beaherrera, I noticed that in the changes you made to the sim_setup.py and conf.py all seem to have changed single quotes (') to double quotes (").

Python doesn't make the distinction between the two, and I personally don't have any hard-and-fast rule on when and how which quotes to use (although I tend to prefer single quotes myself). Is it possible this was something changed by your IDE? If so you will want to disable that because, besides making it hard to look at changes, if you aren't careful automatically changing quote styles can cause other issues.

@beaherrera
Copy link
Author

Hi @kaeldai,

Thank you for reviewing the PR! I'm sorry about that. It’s the auto formatter I use. I’ll fix the commit. I just changed a few lines, which are hard to see among all the changes.

Best,
Beatriz

@beaherrera
Copy link
Author

Hi @kaeldai,

I reverted the commit and removed the auto string normalization. You can see the changes I made to build_env_pointnet() in my last commit 1698d2c

Thanks,
Beatriz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants