Preparations for detecting out of range SetDaScale #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have the pre set event anymore since 20b6ccc (Analysis Functions: Remove PRE_SWEEP_EVENT and repurpose as PRE_SWEEP_CONFIG_EVENT, 2021-06-21).
The pre set comes before the pre sweep event so let's make that clear in the table as well.
48 tasks
t-b
force-pushed
the
bugfix/2293-set-da-scale-limits-prep
branch
2 times, most recently
from
9e01dcd
to
fdee1cc
Compare
These checks are always true, we don't do these check nowadays and don't loose anything if we get rid of them.
If the expected type is not given we need to allow querying non-existent parameters, otherwise functions like PSQ_CR_FindDependentAnalysisParameter always bug out. Broken since d0961b5 (AFH_GetAnalysisParameter: Skip type assertion, 2019-12-12). Also add some tests.
In 2bc24da (PA_SpikePositionsForNonVC: Add missing /Q, 2024-08-01) we added a plain /Q to FindPeak. But the author did not realize that for this operation the /Q implies not erroring out (other operations do that with /Z). So the function currently always bugs out when it finds a peak. By dropping the RTE error handling we can use it correctly.
t-b
force-pushed
the
bugfix/2293-set-da-scale-limits-prep
branch
from
fdee1cc
to
7bd2189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge once CI passes.