tests/CheckThatTheyAllAssertOut: Ignore igortest marker function #2288
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with instrumentation igortest adds a function to mark the
file as instrumented. But as we require all functions in the file to
assert out this makes the test case fail with [1]:
0: is false. Assertion "FAIL()" failed in AnalysisFunctionPrototypeTests#CheckThatTheyAllAssertOut (UTF_AnalysisFunctionPrototypes.ipf, line 43)
? Function IUTF_TagFunc_bd1f27ca745da4aa90f393ef89b21e4aa84abb5a97b8b36526b552cdeffad1d2_IGNORE
Therefore we have to remove these tag functions from our function list.
Broken since 2d62af6 (MIES_AnalysisFunctionPrototypes.ipf: Assert out, 2024-10-22).
[1]: https://github.com/AllenInstitute/MIES/actions/runs/11467629096/job/31913142347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with instrumentation igortest adds a function to mark the file as instrumented. But as we require all functions in the file to assert out this makes the test case fail with 1:
0: is false. Assertion "FAIL()" failed in AnalysisFunctionPrototypeTests#CheckThatTheyAllAssertOut (UTF_AnalysisFunctionPrototypes.ipf, line 43)
Therefore we have to remove these tag functions from our function list.
Broken since 2d62af6 (MIES_AnalysisFunctionPrototypes.ipf: Assert out, 2024-10-22).
Close #2287
Will merge when CI passes.