Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance error message for mismatched waves with basic SF operations #2238

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Enhance error message for mismatched waves with basic SF operations #2238

merged 2 commits into from
Sep 3, 2024

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Aug 19, 2024 •
edited
Loading

Close #2237

@t-b
GetWaveDimensions: Add it
5583b7e 
Although the function is rather short, it is still nicer to have a single
instance of the code. We also choose to use a double precision wave as
that holds all possible current wave sizes and does not have the various
issues as the 64bit integer waves have.
@t-b
MIES_SweepFormula.ipf: Enhance mismatched waves message for basic mat…
ba7eb21 
…h operations
@t-b t-b self-assigned this Aug 19, 2024
@t-b t-b mentioned this pull request Aug 19, 2024
Merged
14 tasks
@t-b t-b assigned timjarsky and unassigned t-b Aug 20, 2024
@t-b t-b enabled auto-merge August 20, 2024 14:34
@timjarsky timjarsky assigned t-b and unassigned timjarsky Aug 30, 2024
@t-b t-b merged commit 177bfaa into main Sep 3, 2024
20 checks passed
@t-b t-b deleted the bugfix/2238-better-error-message-basic-sf-operations branch September 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky timjarsky approved these changes

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth is a code owner

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SweepFormula: Enhance error message for wave mismatch for basic math operations
2 participants
@t-b @timjarsky