Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin hdmf and pynwb #2720

Merged
merged 2 commits into from
Sep 8, 2023
Merged

unpin hdmf and pynwb #2720

merged 2 commits into from
Sep 8, 2023

Conversation

mikejhuang
Copy link
Contributor

@mikejhuang mikejhuang commented Sep 8, 2023 •
edited
Loading

hdmf version testing

  • 3.9.0 PASS
  • 3.8.0 FAILED
    • FAILED allensdk/test/brain_observatory/ecephys/test_write_nwb.py::test_write_probe_lfp_file_roundtrip[True] - ValueError: io has already been set for this container (name=root, type=<class 'pynwb.file.NWBFile'>)
    • FAILED allensdk/test/brain_observatory/ecephys/test_write_nwb.py::test_write_probe_lfp_file_roundtrip[False] - ValueError: io has already been set for this container (name=root, type=<class 'pynwb.file.NWBFile'>)
  • 3.7.0 FAILED
    • FAILED allensdk/test/brain_observatory/ecephys/test_write_nwb.py::test_write_probe_lfp_file_roundtrip[True] - ValueError: io has already been set for this container (name=root, type=<class 'pynwb.file.NWBFile'>)
    • FAILED allensdk/test/brain_observatory/ecephys/test_write_nwb.py::test_write_probe_lfp_file_roundtrip[False] - ValueError: io has already been set for this container (name=root, type=<class 'pynwb.file.NWBFile'>)
  • 3.5.0 FAILED
    • FAILED allensdk/test/brain_observatory/ecephys/test_write_nwb.py:test_add_invalid_times - ValueError: Invalid dataset identifier (invalid dataset identifier)
  • 3.4.7 PASS

Fixed issue link hdmf-dev/hdmf#914

@mikejhuang
Copy link
Contributor Author

The linting fail is on a file I didn't touch. Perhaps some of the other commits in rc/2.16.0 is not fully linted.

@mikejhuang mikejhuang force-pushed the unpin_hdmf_and_pynwb branch 2 times, most recently from ce8bf09 to 5a01b0c Compare September 8, 2023 21:05
@mikejhuang
unpin hdmf and pynwb
f952b32
@mikejhuang
exclude failed version ranges from hdmf
0b3d496 
exclude older versions of hdmf

exclude specific versions of hdmf

exclude specific versions of hdmf2
@mikejhuang mikejhuang merged commit deab76b into rc/2.16.0 Sep 8, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morriscb morriscb morriscb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikejhuang @morriscb