-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vbn lfp behavior tutorials #2640
Vbn lfp behavior tutorials #2640
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Corbett Bennett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@@ -0,0 +1,2481 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use a seeded random number generator here instead? This way the notebook execution will be consistent from run to run. https://numpy.org/doc/stable/reference/random/generator.html
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add some more info, we added a workflow to run notebooks when they get merged into the main branch, so that we can make sure it runs and also update it with the latest code. The notebook will change without a seed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok just added the seed before calling random.choice. Is this what you meant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Note to team pika: due to the notebook runner workflow, we'll have to parameterize the path to the manifest since the dummy path will crash. We'll have to make this change once this is merged.
Overview:
We recently released LFP and behavior-only data for Visual Behavior Neuropixels. This PR adds two tutorials to show users how to take advantage of this new data. I've also updated the docs page to include links to these notebooks (though this should be tested since this is my first time adding these).
Type of Fix:
functionality to not work as expected)
Changes:
Validation: