use yarn, upgrade react-router v3, fixed issue #802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AllenFang,
Yarn install
This is PR with yarn and dependencies fix
Install yarn
Fixed dependencies issue
React, React Bootstrap
use react version 15.3.0 cause PropTypes#7132 issue from react-bootstrap v0.29.5 so I upgrade react-bootstrap v0.30.0#2095 to resolve this issue.
React Router
I try to upgrade react-router to avoid history dependencies issue by version 3.0.0(link) which use
history
dependencies itself, so we can didn't care abouthistory
dependencies.use
now react-router 3.0.0 working fine.
Now dependencies version
Test working version
react, react-dom: 0.14.7, 15.0.0, 15.3.0 (all pass)
Have some suggestion feel free to discussion with me 👍