-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search fails on columns in data set but not included in table #213
Comments
@sandikbarr, thanks your suggestions :) if interesting, you can join gitter :) Anyway, about your problem, could please give me your examples code? because Thanks 👍 |
Hi. Here is a rough example showing the problem I am having: https://github.com/sandikbarr/show-me-what-you-got If you use the custom search control I added, it errors with "Cannot read property 'format' of undefined" (Sorry about all the linting errors, it's late here. Lmk if you have any trouble getting it running.) |
Fixed it, check the |
I updated my example at https://github.com/sandikbarr/show-me-what-you-got to v1.4.2. I'm seeing a lot of "Uncaught TypeError: Cannot read property '__html' of undefined" errors when I use my custom filter. I also tried 1.4.3, and I saw the same errors when I used the clear button on my custom search. My custom filter is just calling the handleFilterData, and search is calling handleSearch. Let me know how I can help track this down. Thanks. |
@sandikbarr, I'll check this out :) |
@sandikbarr, sorry for a long fixing, please check the newest version :0 |
The search function fails with error in v1.4.1/src/store/TableDataStore.js line 210, Cannot read property 'format' of undefined. I have a dataset where not all columns are included in the table. colInfos[key] from the row set is undefined, so it fails with error.
(Also a request: Since you are in very active development, it would be super helpful if you could distribute with source maps to help us help you.)
The text was updated successfully, but these errors were encountered: