Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sizePerPageList issue: 'close' class gets erased #1257

Closed
pinkynrg opened this issue Apr 25, 2017 · 5 comments
Closed

sizePerPageList issue: 'close' class gets erased #1257

pinkynrg opened this issue Apr 25, 2017 · 5 comments

Comments

@pinkynrg
Copy link

Good afternoon,

I just made big changes to the project I'm working on, so I can't understand if the issue I'm having is due to the changes I made or the actual library version.

What is happening is that I click on the list (which adds an 'open' class to it). Once the parent component updates the state, the child re-render, and the list closes (the class 'open' disappears). This wasn't happening with the old version of my software.

@pinkynrg pinkynrg changed the title SizePerPageList issue: 'close' class gets erased sizePerPageList issue: 'close' class gets erased Apr 25, 2017
@AllenFang
Copy link
Owner

yes, after v3.0.0 will have this effect. The problem is in v3.0.0 I remove the bootstrap.js and jquery dependency, so I need to control the open/close state in react component. I'll try to improve it but not sure can fix it. Let me know if you have any concern, thanks

@AllenFang
Copy link
Owner

ok, after a quick look, I think it's hard to fix, because it's native behavior for bootstrap, if dropdown open and you click outside of dropdown, it will close.

@pinkynrg
Copy link
Author

pinkynrg commented Apr 26, 2017

The thing is that I'm not clicking anywhere for it to close.

I have this table that updates its content every 3 seconds lets' say. let's say that I click on the pageSizeList bootstrap list, once the 3 seconds expire the list will close by itself, without me clicking anywhere.

@AllenFang
Copy link
Owner

got it, I'll spend some time to check this one.

AllenFang added a commit that referenced this issue May 6, 2017
@AllenFang
Copy link
Owner

Fixed on v3.3.1, enable options.keepSizePerPageState. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants