Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
AllenFang committed Aug 27, 2016
1 parent ecc6a16 commit ffb8031
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ gulp.task('prod', ['umdBuild'], function() {
gulp.src('./css/react-bootstrap-table.css')
.pipe(concatCss("./react-bootstrap-table.min.css"))
.pipe(cssmin())
.pipe(gulp.dest('./css'));
.pipe(gulp.dest('./dist'));

This comment has been minimized.

Copy link
@r-anup

r-anup Aug 27, 2016

How can you change such a dramatic thing without any documentation!

This comment has been minimized.

Copy link
@AllenFang

AllenFang Aug 28, 2016

Author Owner

sorry, i only update README, I'll update CHANGELOG and document quickly. Thanks your remind

gulp.src(['./css/react-bootstrap-table.css', './css/toastr.css'])
.pipe(concatCss('./react-bootstrap-table-all.min.css'))
.pipe(cssmin())
.pipe(gulp.dest('./css'));
.pipe(gulp.dest('./dist'));
});

// build umd bundles for https://npmcdn.com/ and for browser <script> tag
Expand Down

2 comments on commit ffb8031

@jflayhart
Copy link

@jflayhart jflayhart commented on ffb8031 Aug 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this mean we don't need to do any custom @import 'react-bootstrap-table/dist/react-bootstrap-table.min.css'; and this is done automatically now? Because when I include it, none of your props like bordered={true} seem to have any effect.

@AllenFang
Copy link
Owner Author

@AllenFang AllenFang commented on ffb8031 Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jflayhart , no, you still need to include the css, I just change the file path of css files.

Please sign in to comment.