Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/Clarify-bioformats-requires-java-and-mvn #72

Merged

Conversation

psobolewskiPhD
Copy link
Collaborator

This PR adds updates the README regarding the bioformats reader requiring java and mvn. Then in installation section, it also strongly suggests using conda-forge to install bioformats_jar.

See discussion here: #46 (comment)

This should resolve that issue—I'm not sure how better to address it anyways.

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [admin/build-py39 #12], adds tiff file format support
  • Provide context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.88 🎉

Comparison is base (2e8cdb7) 87.55% compared to head (4a34b65) 88.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   87.55%   88.44%   +0.88%     
==========================================
  Files           4        3       -1     
  Lines         209      199      -10     
==========================================
- Hits          183      176       -7     
+ Misses         26       23       -3     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evamaxfield
Copy link
Collaborator

Looks good to me! Thanks for all your work recently ❤️

@evamaxfield evamaxfield merged commit 2b00d40 into AllenCellModeling:main Mar 10, 2023
@psobolewskiPhD psobolewskiPhD deleted the psobolewskiPhD-patch-1 branch March 10, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants