Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/bump-min-aicsimageio-to-resolve-czi-physical-pixel-sizes #44

Conversation

evamaxfield
Copy link
Collaborator

This resolves a build failure that occurred due to an upstream aicsimageio change with how physical pixel sizes are read from CZI metadata.

As a result the min aicsimageio is going up to a specific patch version of 4.6.3.

@evamaxfield evamaxfield added the bug Something isn't working label Mar 7, 2022
@evamaxfield evamaxfield self-assigned this Mar 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #44 (88b455b) into main (64cbee1) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   83.59%   83.51%   -0.09%     
==========================================
  Files           7        5       -2     
  Lines         189      182       -7     
==========================================
- Hits          158      152       -6     
+ Misses         31       30       -1     
Impacted Files Coverage Δ
napari_aicsimageio/tests/test_core.py 100.00% <ø> (ø)
napari_aicsimageio/tests/__init__.py
napari_aicsimageio/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64cbee1...88b455b. Read the comment docs.

@evamaxfield evamaxfield merged commit 95321f5 into main Mar 7, 2022
@evamaxfield evamaxfield deleted the admin/bump-min-aicsimageio-to-resolve-czi-physical-pixel-sizes branch March 7, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants