Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/use-physical-pixel-size-for-scales #20

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

evamaxfield
Copy link
Collaborator

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [admin/build-py39 #12], adds tiff file format support
  • Provide context of changes.

Uses the scales parameter on view image to help napari show the actual size of the pixels.

  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@evamaxfield evamaxfield added the enhancement New feature or request label Jul 16, 2021
@evamaxfield evamaxfield self-assigned this Jul 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #20 (22bc256) into main (36f138e) will increase coverage by 2.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   71.57%   73.78%   +2.20%     
==========================================
  Files           5        5              
  Lines          95      103       +8     
==========================================
+ Hits           68       76       +8     
  Misses         27       27              
Impacted Files Coverage Δ
napari_aicsimageio/tests/test_core.py 100.00% <ø> (ø)
napari_aicsimageio/core.py 75.40% <100.00%> (+3.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f138e...22bc256. Read the comment docs.

@evamaxfield evamaxfield merged commit 882583d into main Jul 16, 2021
@evamaxfield evamaxfield deleted the feature/use-physical-pixel-size-for-scales branch July 16, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants