Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/remote-read-from-http #17

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

evamaxfield
Copy link
Collaborator

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [admin/build-py39 #12], adds tiff file format support

Resolves #16

  • Provide context of changes.

I decided against installing s3fs and gcsfs by default because s3fs / boto is a really hard dependency to manage and I wouldn't want to toss that on anyone without them realizing it. So just http support by default. If users want to read from s3 or gcs they can follow the README in aicsimageio main

  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@evamaxfield evamaxfield added bug Something isn't working enhancement New feature or request labels Jul 12, 2021
@evamaxfield evamaxfield self-assigned this Jul 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #17 (d22ca44) into main (7d89269) will decrease coverage by 3.84%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   75.26%   71.42%   -3.85%     
==========================================
  Files           5        5              
  Lines          93       98       +5     
==========================================
  Hits           70       70              
- Misses         23       28       +5     
Impacted Files Coverage Δ
napari_aicsimageio/core.py 71.42% <0.00%> (-7.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d89269...d22ca44. Read the comment docs.

@evamaxfield
Copy link
Collaborator Author

Huh. Well unfortunately @haesleinhuepf, it seems like fsspec http read splits the read into multiple parts because I get a: 429, message='Too Many Requests', url=URL('https://zenodo.org/record/5090508/files/Haase_MRT_tfl3d1.tif?download=1') error.

So I just went ahead and added a catch-all route for file reading that will allow napari to move on to the next reader available.

@evamaxfield evamaxfield merged commit 59059df into main Jul 12, 2021
@evamaxfield evamaxfield deleted the bugfix/remote-read-from-http branch July 12, 2021 06:15
@haesleinhuepf
Copy link
Contributor

Hi @JacksonMaxfield,

awesome, thanks for the immediate response!

Best,
Robert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while opening image via HTTPS
3 participants