Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/update-to-support-4.0 #14

Merged
merged 10 commits into from
Jun 29, 2021
Merged

feature/update-to-support-4.0 #14

merged 10 commits into from
Jun 29, 2021

Conversation

evamaxfield
Copy link
Collaborator

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [admin/build-py39 #12], adds tiff file format support

Resolves #13

  • Provide context of changes.

Brings the napari plugin up-to-date with 4.0. We lose the multi-scene functionality as that needs to be handled in the future with state. But overall we gain nice features. All formats are supported, we have mosaic support now. And hopefully some more documentation.

  • Provide relevant tests for your feature or bug fix.

We use the same test / resources as aicsimageio main.

  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@evamaxfield evamaxfield added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 29, 2021
@evamaxfield evamaxfield self-assigned this Jun 29, 2021
@evamaxfield evamaxfield changed the base branch from master to main June 29, 2021 16:45
@evamaxfield evamaxfield requested a review from toloudis June 29, 2021 17:43
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Attention: Patch coverage is 84.48276% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (dd26dd3) to head (525b43e).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
napari_aicsimageio/core.py 79.06% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (dd26dd3) and HEAD (525b43e). Click for more details.

HEAD has 91 uploads less than BASE
Flag BASE (dd26dd3) HEAD (525b43e)
99 8
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   81.57%   75.26%   -6.32%     
==========================================
  Files           6        5       -1     
  Lines          76       93      +17     
==========================================
+ Hits           62       70       +8     
- Misses         14       23       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evamaxfield evamaxfield merged commit 36583ab into main Jun 29, 2021
@evamaxfield evamaxfield deleted the feature/4.0-update branch June 29, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while enabling the Plugin in Napari
2 participants