Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add sincos pos embed #416

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

benjijamorris
Copy link
Contributor

What does this PR do?

  • consolidate positional embedding into single function
  • add fixed sincos positional embedding

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

ritvikvasan
ritvikvasan previously approved these changes Aug 14, 2024
Copy link
Member

@ritvikvasan ritvikvasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Can you add some comments about when learnable vs non learnable and sinusoidal vs non sinusoidal is preferable?

@benjijamorris
Copy link
Contributor Author

done!

@benjijamorris benjijamorris merged commit 4b94064 into main Aug 14, 2024
1 of 6 checks passed
@benjijamorris benjijamorris deleted the feature/add_sincos_pos_embed branch August 14, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants